1004428 - CSS errors in about:accounts

Status: RESOLVED DUPLICATE of bug 1395460

(Firefox :: Sync, defect, P3)

Description

[:Gijs (out for now; he/him)]

From bug 971096's automated checker:

Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element '-webkit-search-cancel-button'.  Ruleset ignored due to bad selector." {file: "<snip>browser/content/browser/aboutaccounts/normalize.css" line: 366 column: 22 source: "input[type="search"]::-webkit-search-cancel-button,"}]
Console message: [JavaScript Warning: "Error in parsing value for 'min-height'.  Declaration dropped." {file: "<snip>browser/content/browser/aboutaccounts/main.css" line: 127 column: 16 source: "    min-height: none;"}]
Console message: [JavaScript Warning: "Expected media feature name but found 'min-device-pixel-ratio'." {file: "<snip>browser/content/browser/aboutaccounts/main.css" line: 146 column: 17 source: "only screen and (min-device-pixel-ratio: 2),"}]

All of these seem like issues we should just fix. about:accounts will never be loaded in another web browser (right?) and so the webkit-specific stuff is just strange. The right "no min-height" value would be 0, not "none".

Tim, does this make sense? Do you know why we're even using normalize.css (I'm assuming we're using one of the many versions on the web) when we know what browser we're running in etc.?

Comment 1

[:Gijs (out for now; he/him)]

Zach, can you have a look? :-)

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

(In reply to :Gijs Kruitbosch from comment #0)
> Tim, does this make sense? Do you know why we're even using normalize.css
> (I'm assuming we're using one of the many versions on the web) when we know
> what browser we're running in etc.?

about:accounts shares a lot of styles with the hosted page and that's why a shared normalize.css was used I think. We should definitely get rid of those and not ship that in the browser.

Zach would be the right person to pick this up when he finds the time to do so! :)

Comment 3

[Zachary Carter [:zaach]]

Normalizing stylesheets make the enterprise of CSS design slightly more sane (or slightly less insane), even when you're targeting a single browser. Default styles (and other forms of implicit state in programming) are the path to confusion and pain.

We should definitely trim the fat and fix errors, though.