1004431 - Broken CSS in OS X's downloads.css

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect)

Description

[:Gijs (he/him)]

Found through bug 971096:

[JavaScript Warning: "Function token for non-function pseudo-class or pseudo-element, or the other way around, when reading 'not'.  Ruleset ignored due to bad selector." {file: "jar:file:///Users/gkruitbosch/dev/builds/obj-x86_64-apple-darwin13.1.0/dist/firefox/Nightly.app/Contents/MacOS/browser/omni.ja!/chrome/browser/skin/classic/browser/downloads/downloads.css" line: 220 column: 95 source: "#downloadsPanel[keyfocus] > #downloadsListBox > richlistitem[type="download"][state="1"]:hover:not[selected] > stack > .downloadButton.downloadShow {"}]


And five more of these, because it should be :not([selected]). The parentheses are required. This seems to have been copied for all platforms in bug 819428. Mike, can you check if nothing breaks if we properly enable these rules? :-)

Comment 1

[:Gijs (he/him)]

Oops, I was wrong, this is OS X specific.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Oh wow, yeah, it's sad this got through review, but it's also a really really edge-y case.

This takes me back.

So this is causing a very slight bug, and I'll give STR for our QA folk right now:

1) Start Firefox, and download two files so that you have two items in the downloads panel.
2) Open the downloads panel with the mouse
3) Hover your mouse over the magnifying glass icon so that it has the circle hover effect on it.
4) Press Tab to focus the first item with your keyboard, and then press the down cursor to select the second item.

AR: The Find icon in the first download item does not have the hover icon anymore.

ER: With the mouse still technically hovering the first download item's "Find" icon, it should still have the hover effect, even though the second download item is selected via keyboard.

Yes, we should go ahead and fix these rules. rs=me.

Comment 3

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/9c0ab8f376e6

Thanks!

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/706bc42060aa

Comment 5

[Camelia Badau [:cbadau], Desktop Test Engineering]

Reproduced the bug on Nightly 2014-05-01. 

Verified fixed on Mac OSX 10.8.5 using Firefox 32 Beta 8 (buildID: 20140818191513).