1004510 - Support PRANSWER in WebRTC JSEP signaling protocol

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Description

[Randell Jesup [:jesup] (needinfo me)]

PRANSWER is part of the JSEP draft/plans

Comment 1

[Maire Reavy [:mreavy]]

Hey Adam -- How much work is involved to add PRANSWER?  Some folks from our community are very interested in knowing what's involved to add this and where this might fall on our roadmap.

Comment 2

[Adam Roach [:abr]]

In theory, this shouldn't be a huge amount of work. Basically, we need to replicate the "inband ringing" behavior from fsmdef_ev_out_alerting (in fsmdef.c) when we see PRANSWER messages (see the switch statements in fsmdef_ev_setlocaldesc and fsmdef_ev_setremotedesc). The tricky part here is ensuring that the subsequent final answer can be processed without blowing stuff up. We know that this isn't currently the case (which is why renegotiation is currently disabled) -- but if we fix this for renegotiation, then it would be fixed for PRANSWER (and vice-versa).

So, if we land Bug 857115 first, then PRANSWER should be a pretty minor tweak in the signaling code; if we don't, then we need to fix whatever causes things to break when we try to modify an ongoing media stream as a prerequisite... and that might be a fairly large chunk of work.

Comment 3

[2423086414]

Issue - I still see this error in the js console:"NotSupportedError: pranswer not yet implemented";when i use the pranswer; I try Firefox 41 and Firefox Nightly; They both failed.

Comment 5

[Rajmohan Banavi]

is there any update on the time line for this?

Comment 6

[Bulk Bug Changes for mreavy's org]

Mass change P3->P4 to align with new Mozilla triage process.

Comment 7

[Byron Campen [:bwc]]

This could end up being tricky, and it probably makes sense to start on this early to discover just how tricky it will be, and what it will interact with. pranswer is (in part) an explicit way of setting up early media (see bug 2019381), so these two bugs will probably be worked at the same time.

Comment 8

[Byron Campen [:bwc]]

Attachment: Bug 1004510: Test-cases for pranswer. r?mjf

Comment 9

[Byron Campen [:bwc]]

Attachment: Bug 1004510: pranswer support r?mjf

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ddfa9124da3c
https://hg.mozilla.org/integration/autoland/rev/5620ff945e61
Test-cases for pranswer. r=mjf
https://github.com/mozilla-firefox/firefox/commit/8dcb9314583f
https://hg.mozilla.org/integration/autoland/rev/66ac024fcece
pranswer support r=mjf

Comment 11

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/5620ff945e61
https://hg.mozilla.org/mozilla-central/rev/66ac024fcece

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/62891 for changes under testing/web-platform/tests

Comment 13

[Dianna Smith [:diannaS]]

:bwc did you want to mention this in the 158 release notes? Please nominate if so.

Comment 14

[Byron Campen [:bwc]]

(In reply to Dianna Smith [:diannaS] from comment #13)

:bwc did you want to mention this in the 158 release notes? Please nominate if so.

Haha, no. This feature is kinda stupid, but it's in the spec and interop 2026, so here we are.