1004597 - keyboard misses letter õ

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Otto de Voogd [:ottodv]]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20140319112400

Steps to reproduce:

Trying to add a name that contains the letter õ

Estonian names can contain: ä, õ, ö or ü.
3 of those 4 letters are available via the keyboard, but õ is not.


Actual results:

There is no letter õ available


Expected results:

The letter probably should be available.

Comment 1

[Rabbi Hossain]

On which keyboard, it is missing? Is it missing on Standard English Keyboard?

Comment 2

[Otto de Voogd [:ottodv]]

The standard keyboard, in Settings it is called "Built-in Keyboard".

If you keep the letter "o" pressed down, you'll see a whole range of non-English characters, like: ò ó ô ö ɵ œ ø to choose from, but the õ (which is between ô and ö in the character table) is missing. It's an important letter in Estonian, many of my contacts have it in their names. And when Firefox OS will launch in Estonia it's proably a good idea to have this letter in there...

Comment 3

[Rabbi Hossain]

Attachment: Patch To Fix This Issue

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8423089 [details] [review]
Patch To Fix This Issue

The patch itself is simple enough to get a r+.
However, this would require UX's confirmation on this, since it would modify the alternative char menu of English.

Note: Ask for UX input becuase I could see this special char 'õ' on English layout of iOS.
Otherwise, I probably would suggest we add this into a separate layout for Estonian.

Comment 5

[Rabbi Hossain]

Since this char is included in other Smartphone OS keyboards, so we also can include this char.
Since we added other alternative chars on the keyboard, we also can include this. 


Let's see what UX Team says.

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8423089 [details] [review]
Patch To Fix This Issue

Point this to a specific UX to get attention.
Omega, could you please help take a look at this issue, since this modified the English alternative char list.

Thanks.

Comment 7

[Omega Feng [:Omega] [:馮於懋]]

Comment on attachment 8423089 [details] [review]
Patch To Fix This Issue

I think there is no problem to add this character.

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Rabbi,

If possible, please help update your commit message as follows,
Bug 1004597 - Add õ to the alternative char menu of English layout.

And then we could merge your patch, thanks.

Comment 9

[Rabbi Hossain]

Hello Rudy,

Thanks for your concern regarding this bug. Currently I am out of network and I am using shared PC's where I don't have access to change this commit message. Could you please do it while merging this pull request?

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch V1

Send another pull request to change the commit message.
Will merge it after Travis is green.

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8450083 [details] [review]
Patch V1

Carry forward the r+ from myself.

Comment 12

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/dc23ec0dab0cc7306f4c627a67a86caa621ee4e9

Comment 13

[Sue]

Attachment: verify_video.MP4

This issue has been verified successfully on Flame v2.1
STR:
1. Launch Contacts app.
2. Tap "+" to add a new contact.
3. Tap Name text box.
4. Long press at "o" key and input "õ".
**The "õ" key is available. 
See attachment: verify_video.MP4
Reproducing rate: 0/5
Flame 2.1 versions:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141130.034738
FW-Date         Sun Nov 30 03:47:49 EST 2014
Bootloader      L1TC00011880