Closed Bug 1004628 Opened 8 years ago Closed 8 years ago

we should run 'make check' on desktop nightly builds

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jlund, Unassigned)

Details

Attachments

(2 files)

No description provided.
dump_masters tells me this is a no-op patch. However it is needed as my accompanying buildbotcustom patch will add:
      checkTest=pf.get('enable_checktests', Fales)

to our factory init that is used for nightly builds. So without this bbot-cfgs patch, we would fail when trying to:
    http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#264

If we actually want 'make -k check' for gecko localizer builders, I think we just need to add the platform as a key in getPlatformMinidumpPath()
Attachment #8416145 - Flags: review?(catlee)
adds 'make -k check' step to nightly builders

passes dump_master/checkconfig (with accompanying bbot-cfgs patch)
Attachment #8416146 - Flags: review?(catlee)
Comment on attachment 8416146 [details] [diff] [review]
140501_bug_1004628_checktest_on_nightlies-bbotcustom.patch

Review of attachment 8416146 [details] [diff] [review]:
-----------------------------------------------------------------

please include more context in your patches!
Attachment #8416146 - Flags: review?(catlee) → review+
Attachment #8416145 - Flags: review?(catlee) → review+
Comment on attachment 8416145 [details] [diff] [review]
140501_bug_1004628_checktest_on_nightlies-bbotcfgs.patch

on default -> https://hg.mozilla.org/build/buildbot-configs/rev/9c02bf494026
Attachment #8416145 - Flags: checked-in+
Comment on attachment 8416146 [details] [diff] [review]
140501_bug_1004628_checktest_on_nightlies-bbotcustom.patch

on default -> https://hg.mozilla.org/build/buildbotcustom/rev/d8364be0b95c
Attachment #8416146 - Flags: checked-in+
Merged and deployed to production.
Component: Release Automation → General Automation
QA Contact: bhearsum → catlee
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.