1004628 - we should run 'make check' on desktop nightly builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Comment 1

[Jordan Lund (:jlund)]

Attachment: 140501_bug_1004628_checktest_on_nightlies-bbotcfgs.patch

dump_masters tells me this is a no-op patch. However it is needed as my accompanying buildbotcustom patch will add:
      checkTest=pf.get('enable_checktests', Fales)

to our factory init that is used for nightly builds. So without this bbot-cfgs patch, we would fail when trying to:
    http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#264

If we actually want 'make -k check' for gecko localizer builders, I think we just need to add the platform as a key in getPlatformMinidumpPath()

Comment 2

[Jordan Lund (:jlund)]

Attachment: 140501_bug_1004628_checktest_on_nightlies-bbotcustom.patch

adds 'make -k check' step to nightly builders

passes dump_master/checkconfig (with accompanying bbot-cfgs patch)

Comment 3

[Chris AtLee [:catlee]]

Comment on attachment 8416146 [details] [diff] [review]
140501_bug_1004628_checktest_on_nightlies-bbotcustom.patch

Review of attachment 8416146 [details] [diff] [review]:
-----------------------------------------------------------------

please include more context in your patches!

Comment 4

[Jordan Lund (:jlund)]

Comment on attachment 8416145 [details] [diff] [review]
140501_bug_1004628_checktest_on_nightlies-bbotcfgs.patch

on default -> https://hg.mozilla.org/build/buildbot-configs/rev/9c02bf494026

Comment 5

[Jordan Lund (:jlund)]

Comment on attachment 8416146 [details] [diff] [review]
140501_bug_1004628_checktest_on_nightlies-bbotcustom.patch

on default -> https://hg.mozilla.org/build/buildbotcustom/rev/d8364be0b95c

Comment 6

[Chris Cooper [:coop] (he/him)]

Merged and deployed to production.