1004710 - [B2G][Dialer]Creating a new contact and tapping on a text field in the dialer app causes a white bar to cover part of the screen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Andrew Stole [:astole]]

Attachment: logcat

When adding a new contact or editing a contact while in the dialer app, a white bar appears in the middle of the screen and bottom of the screen when tapping on any text field to bring up the keyboard.

Repro Steps:
1) Update a Open_C to BuildID: 20140501040203
2) Open the dialer app
3) Select the contact tab
4) Create a new contact or edit an existing one
5) Tap on a text field box

Actual:
Once the keyboard is brought up, a white bar appears vertically in the middle of the screen

Expected:
No white bar appears

2.0 Environmental Variables:
Device: Open_C 2.0 MOZ
BuildID: 20140501040203
Gaia: 8873166797fecfa65c0afa644d2ebcc7d7cb4ed3
Gecko: b227a707080f
Version: 32.0a1
Firmware Version: P821A10-ENG-20140410

Repro frequency: 100%
See attached: Video, logcat

Comment 1

[Natalya Kot [:nkot]]

'qawanted' to test on Buri trunk and on Open_C 1.4

Comment 2

[Andrew Stole [:astole]]

This issue also occurs on Buri trunk.

2.0 Master M/C Environmental Variables:
Device: Buri 2.0 Master M/C MOZ
BuildID: 20140501040203
Gaia: 8873166797fecfa65c0afa644d2ebcc7d7cb4ed3
Gecko: b227a707080f
Version: 32.0a1
Firmware Version: V1.2-device.cfg

This issue does not occur on 1.4 on latest Open_C.

1.4 Environmental Variables:
Device: Open_C 1.4 MOZ
BuildID: 20140501000200
Gaia: 011330c45f575d5a87332e605be47f570faf10ca
Gecko: a9db863ae8c2
Version: 30.0
Firmware Version: P821A10-ENG_20140410

Comment 3

[Jason Smith [:jsmith]]

This needs a video.

Comment 4

[Andrew Stole [:astole]]

Attaching video and adding regressionwindow-wanted.

Comment 5

[Chris Kreinbring [:CKreinbring]]

Regression windows:

B2G Inbound
No repro
Build ID: 20140428083656
Gecko: https://hg.mozilla.org/integration/b2g-inbound/rev/740e32b280d4
Gaia: a68154488f5f6c4dfe1c05f4dde8ade8641af227
Platform Version: 31.0a1
Firmware Version: V1.2-device.cfg

Repro
Build ID: 20140428084656
Gecko: https://hg.mozilla.org/integration/b2g-inbound/rev/1844c4a8c912
Gaia: cba203c750d3364f3e3971ea8a0ec315ced784d3
Platform Version: 31.0a1
Firmware Version: V1.2-device.cfg

Old Gaia / New Gecko - OK
New Gaia / Old Gecko - Fail
Push log: https://github.com/mozilla-b2g/gaia/compare/a68154488f5f6c4dfe1c05f4dde8ade8641af227...cba203c750d3364f3e3971ea8a0ec315ced784d3


Tinderbox
No repro
Build ID: 20140428155836
Gecko: https://hg.mozilla.org/mozilla-central/rev/b681a6daea3b
Gaia: cadddcac2b8ce162a5e27e6dc105557b00a94478
Platform Version: 32.0a1
Firmware Version: V1.2-device.cfg

Repro
Build ID: 20140428162136
Gecko: https://hg.mozilla.org/mozilla-central/rev/d7c07694f339
Gaia: 725a23802708eb70e3d7e8a2ce7179adbac806e4
Platform Version: 32.0a1
Firmware Version: V1.2-device.cfg

Comment 6

[Jason Smith [:jsmith]]

Either bug 987061 or bug 987791 caused this.

Comment 7

[Jason Smith [:jsmith]]

Arnau - Can you indicate which bug caused this & look into this?

Comment 8

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

I think this is caused by the screen refresh.
I can also reproduce this in my peak.
ni: Jose Manuel.

Comment 9

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: contacts_1.png

Comment 10

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: contacts_2.png

Comment 11

[Jose Manuel Cantera]

I have any cue about what could be happening.

Tim, Vivien, any idea?

Comment 12

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Sounds like an APZ bug.

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Yeah this looks like the gaia changes exposed some underlying bug in the platform. From the screenshots and video it looks like maybe some tiles aren't getting painted properly. CC'ing chris/nical.

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Agree with comment 12.

Comment 15

[Kartikaya Gupta (email:[e-mail])]

Attachment: Screenshot with layer+tile borders

Definitely some sort of tiling problem; the white area is a misplaced(?) tile.

Comment 16

[Kartikaya Gupta (email:[e-mail])]

Chris, any ideas on what's going on?

Comment 18

[Kartikaya Gupta (email:[e-mail])]

Attachment: Layer dump

Actually there is a layer (0x475e4000 in the attached layer dump) that matches exactly the white areas on the screen. Not sure where it is coming from, but that's likely the problem

Comment 19

[Kartikaya Gupta (email:[e-mail])]

Bug 1008984, which was duped to this one, is a result of the line at [1]. If I disable that translateY in the app manager, the white space at the bottom is filled with the three icons that (I assume) are supposed to still be there. If they're not supposed to be there you need something other than translateY to get rid of them, because they still take up space in the layout. ni? to :yzen who seems to have touched that style most recently.

[1] https://github.com/mozilla-b2g/gaia/blame/master/apps/communications/dialer/style/toolbar.css#L80

Comment 20

[Kartikaya Gupta (email:[e-mail])]

... and the other white rectangle (the one in the middle of the screen) is coming from the CSS rule at https://github.com/mozilla-b2g/gaia/blame/master/apps/communications/dialer/style/toolbar.css#L17

This is totally on the gaia side.

Comment 21

[Jason Smith [:jsmith]]

kats's comments seem to imply that bug 987061 is the cause of this regression.

Comment 22

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Got it! I think is a z-index issue :)
I will add a new patch in this bug so you can test it.

Comment 23

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 24

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Hey guys, could you test this patch? I think it addresses all vertical columns due to tabs Building Block.
I see no other side effect in other apps using tabs (clock and music).

This patch is not fixing comment 19. As described there, tabs are hidden down with translate.

Comment 25

[Jason Smith [:jsmith]]

Note for testing - you'll need clone https://github.com/rnowm/gaia.git & run git checkout 1004710 to get the right branch here to test.

Comment 26

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: 24ba1627cf118846c938130693c592378c2589dd

Comment 27

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Sorry guys, this patch was causing other issues in dialer, so I've backed it out.
I'll prepare another patch, I still think is a z-index related issue in tabs.

Comment 28

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Revert: 8c11e7bd97881d457ff4992cc75530db88607199

Comment 29

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/19275

Comment 30

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

:rik, I can still reproduce this after your patch on a Peak :(

Comment 31

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: bug.png

Comment 32

[Anthony Ricaud (:rik)]

Weird, I don't see that at all on a Peak with my patch applied. It also fixes it.

Comment 33

[Etienne Segonzac (:etienne)]

Comment on attachment 8423048 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19275

I think we have 2 issues here, but yes we should take this patch also.

Comment 34

[Anthony Ricaud (:rik)]

https://github.com/mozilla-b2g/gaia/commit/8d33e328638d0ce0a6e767e6d50f909d517a56f7

Comment 35

[Pi Wei Cheng [:piwei] (inactive)]

Removing qawanted due to bug being marked fixed.