1004838 - More flexible handling of the "people" field

Status: RESOLVED INVALID

(MozReview Graveyard :: General, defect, P2)

Description

[Mark Côté [:mcote]]

At the moment, when a review request is published, the first user in the "people" field (sorted alphabetically) is flagged for review in the attachment posted to the associated Bugzilla bug.  If the people field is later changed (and the review request re-published), a new attachment is created.

Ideally, the existing attachment should be updated with the new reviewer.  A more difficult problem is selecting who should be the reviewer... since the order in which the users are entered into the people field does not appear to be preserved, it might be best to just restrict it to one person, and throw an error otherwise.

Eventually we should have separate fields for reviewer (restricted to one entry) and feedback (as many as desired).

Comment 1

[Mark Côté [:mcote]]

For now, we are restricting the "People" field to exactly one person.

If we change the UI to allow one reviewer and multiple feedbackers, we should store these separately but I think, for all intents and purposes, internally in Review Board we can treat them as all members of the target_people field.  Only the rbbz extension will need to differentiate them.

Comment 2

[Mark Côté [:mcote]]

I was mistaken in my belief that there could only be one reviewer for a given patch/attachment.  I've since fixed rbbz to take any number of reviewers, possibly zero, and to update the list if the review request is subsequently republished.