Closed
Bug 1004881
Opened 11 years ago
Closed 11 years ago
Saved passwords exceptions dialog ignores delete key
Categories
(Toolkit :: Password Manager, defect)
Tracking
()
VERIFIED
FIXED
mozilla32
| Tracking | Status | |
|---|---|---|
| firefox32 | --- | verified |
People
(Reporter: michael, Assigned: michael)
Details
Attachments
(1 file, 1 obsolete file)
|
758 bytes,
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140428193813
Steps to reproduce:
0. Log into a site requiring a password; when prompted click "Never Remember Password for This Site."
1. Open Preferences dialog.
2. Click on Security pane.
3. Click on "Exceptions..." button.
4. Select a site.
5. Press delete or backspace.
Actual results:
Nothing happens when pressing delete or backspace.
Expected results:
The selected site should be deleted from the saved password exceptions. Clicking on the "Remove" button works as expected, but it should be possible to remove the selected saved password exception by pressing delete or backspace.
|
Assignee | |
Comment 1•11 years ago
|
||
The problem is that HandleRejectKeyPress() calls the nonexistent function DeleteRejectSelected() while the "Remove" button calls DeleteReject().
Attachment #8416287 -
Flags: review?(gavin.sharp)
|
|
Assignee | |
Updated•11 years ago
|
Component: Untriaged → Preferences
|
||
Updated•11 years ago
|
Attachment #8416287 -
Flags: review?(gavin.sharp) → review?(MattN+bmo)
|
||
Updated•11 years ago
|
Assignee: nobody → michael
Status: UNCONFIRMED → ASSIGNED
Component: Preferences → Password Manager
Ever confirmed: true
OS: Linux → All
Product: Firefox → Toolkit
Hardware: x86_64 → All
|
|
||
Comment 2•11 years ago
|
||
This patch doesn't apply because it seems to depend on bug 431901.
Depends on: 431901
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8416287 [details] [diff] [review]
Patch
Wow, it looks like this hasn't worked since 2007. Good catch!
Attachment #8416287 -
Flags: review?(MattN+bmo) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
I've updated the patch so that it no longer depends upon my patch for bug 431901.
Attachment #8416287 -
Attachment is obsolete: true
Attachment #8417709 -
Flags: review?(MattN+bmo)
|
|
||
Updated•11 years ago
|
Attachment #8417709 -
Flags: review?(MattN+bmo) → review+
|
|
||
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Comment 5•11 years ago
|
||
Hi Michael (welcome to mozilla and thanks contributing)
could you provide a Try link. Suggestions for what to run if you haven't
yet can be found here:
https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices
Keywords: checkin-needed
|
|
Assignee | |
Updated•11 years ago
|
Summary: Saved passwords exceptions dialog ignores delete and backspace keys → Saved passwords exceptions dialog ignores delete key
|
|
Assignee | |
Comment 6•11 years ago
|
||
|
|
||
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Comment 7•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
|
||
Comment 8•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla32
|
||
Updated•11 years ago
|
QA Whiteboard: [good first verify]
[testday-20140814]
Verified on Windows 7 x64. Now the Del key can be used to remove an exception.
|
|
||
Comment 10•11 years ago
|
||
(In reply to kenkon from comment #9)
> [testday-20140814]
>
> Verified on Windows 7 x64. Now the Del key can be used to remove an
> exception.
Marking as Verified. Thank you kenkon!
Status: RESOLVED → VERIFIED
QA Whiteboard: [good first verify] → [good first verify][testday-20140814]
status-firefox32:
--- → verified
You need to log in
before you can comment on or make changes to this bug.
Description
•