1004890 - Add UI telemetry for the Home Page contextmenu

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: uitelemetry-home-contextmenu v0.1

Simple patch that logs an event for any Home Page contextmenu action. The Android resource name for the action is sent as an Extra.

Comment 1

[Richard Newman [:rnewman]]

Comment on attachment 8416304 [details] [diff] [review]
uitelemetry-home-contextmenu v0.1

Review of attachment 8416304 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 2

[Richard Newman [:rnewman]]

needinfo'ing myself to document this.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/fx-team/rev/34516556f823

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out because Android Armv6 robocop-1 went perma-fail starting with this push.
https://hg.mozilla.org/integration/fx-team/rev/fb88b8685827

https://tbpl.mozilla.org/php/getParsedLog.php?id=38947512&tree=Fx-Team

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #4)
> Backed out because Android Armv6 robocop-1 went perma-fail starting with
> this push.
> https://hg.mozilla.org/integration/fx-team/rev/fb88b8685827
> 
> https://tbpl.mozilla.org/php/getParsedLog.php?id=38947512&tree=Fx-Team

Try run was green. Retriggers of the two failing rc1 runs were both green. Two pushes that completed before the backout were both green.

Relanding: https://hg.mozilla.org/integration/fx-team/rev/62ead59d3f19

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

For completeness, the Try run: https://tbpl.mozilla.org/?tree=Try&rev=41b9dae6d1a8

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/62ead59d3f19

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8416304 [details] [diff] [review]
uitelemetry-home-contextmenu v0.1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: We miss out on some "before changes" telemetry that could show affect of Fx32 changes
Testing completed (on m-c, etc.): Working on m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/805a76aa2924

Comment 10

[Flaviu Cos]

Verified as fixed in builds:
- 32.0a1 (2014-05-29);
- 31.0a2 (2014-05-29);
Device: Samsung Galaxy Nexus (Android 4.2.1).