1004911 - Improve animation performance when showing new tab tile thumbnail/images

Status: RESOLVED WONTFIX

(Firefox :: General, defect)

Description

[Ed Lee :Mardak]

Bug 990212 tracked TART regression when the test started to run with images being shown from directory tiles populating the grid instead of leaving all the tiles blank.

We can potentially improve the performance perhaps by delaying the load/showing of images.

Comment 1

[Lawrence Mandel [:lmandel] (use needinfo)]

[Tracking Requested - why for this release]:

With bug 990713 on Firefox 32, is the performance improvement suggested in this bug for the regression identified in bug 900212 a fix that we need or want to take on Firefox 32 (beta)?

Comment 2

[Avi Halachmi (:avih)]

Personally I think the suggestion in comment 0 is not required, nor fixing it for Firefox 32. I described the reason at bug 990713 comment 13.

As for bug 990713 comment 16 (delaying the images until after the animation is done) I think it's a matter for the UX guys to decide.

If, OTOH, we want to put time into improving tab animation with thumbs/tiles withOUT delaying the images, then it sounds like a great idea, though still not for uplift (and such solution doesn't exist yet even if we wanted to uplift).

Also, I'm not sure how bug 900212 is related...

Comment 3

[Avi Halachmi (:avih)]

(In reply to Avi Halachmi (:avih) from comment #2)

> ... I described the reason at bug 990713 comment 13. ...
> As for bug 990713 comment 16 ...

Bug 990212, not bug 990713. 

> Also, I'm not sure how bug 900212 is related...

Now I do, it's a typo of bug 990212.

Bottom line, I think we can live with this regression, and I don't think we should fix this regression by delaying the thumbs/tiles, unless the UX guys think it's a good idea, and even if we do, it's not uplift material IMO (and we don't have the solution yet).

If we want to explore other speedups without delaying the thumbs, sounds like a good idea, but also not for uplift.

Comment 4

[Ed Lee :Mardak]

(In reply to Lawrence Mandel [:lmandel] from comment #1)
> [Tracking Requested - why for this release]:
> With bug 990713 on Firefox 32
That will be backed out by bug 1039881 for Firefox 32 although I've been running into some test failures when switching the pref to empty (to turn off that functionality).

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

Thank you Ed and Avi for the feedback. Marking at tracking- for 32. I have marked as tracking+ for 33 to revisit whether a fix is a good idea.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Ed, if it still relevant with the new tiles in 33?
If yes, do you think it is going to be fixed for 33?
Thanks

Comment 7

[Ed Lee :Mardak]

There's different performance characteristics being tracked in bug 1059558 tracking34. The original suggestion here of delaying images might be relevant for that bug.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

I think it is too late for 33.1... Tracking it for 34.

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

AFAIK we're not going to have a fix for 34. Marking as wontfix. I also marked tracking for 35 and 36 as I don't want to see the ball drop on this bug.

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

With no assignee and several releases already out, there's not much reason to continue to track this vague bug.  Leaving tracking on for one more release, 36, so that we can look into getting a list of actionable bugs related to fixing this issue instead.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Ed, do you have any plan for this bug? Thanks

Comment 12

[Sylvestre Ledru [:Sylvestre]]

No activity on this bug for a while. I don't see the point of tracking it anymore.

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Clearing the needinfo
Not activity for 2 years, let's wontfix