Closed Bug 1005041 Opened 11 years ago Closed 11 years ago

Disable "Get a call url" button and provide in-progress feedback when getting a call url

Categories

(Hello (Loop) :: Client, defect, P3)

Product:
Hello (Loop)
Component:
Client
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla33

People

(Reporter: standard8, Unassigned)

References

Details

User Story

Things to do:

- Disable "Get a call url" button as soon as it is clicked
- Provide an in-progress indication from when "Get a call url" is clicked until the result is received
- Ensure the "Get a call url" button is re-enabled when getting a new url.

Attachments

(2 files)

https://github.com/adamroach/gecko-dev/pull/20
46 bytes, text/x-github-pull-request
dmosedale
: review+
Details | Review
https://github.com/mozilla/loop-client/pull/27
46 bytes, text/x-github-pull-request
dmosedale
: review+
Details | Review
Currently when we get a call url, we don't update the display until we have the result - this can allow the user to click twice and generate two or more requests unnecessarily. In bug 994151 I will be introducing potential further delays for service registration on the first time requests, and maybe on the first time after load (if it is quick). Therefore, I think we should have some sort of disabling of the call url button and an in-progress indication. This seems like it can be separate to bug 994151, so separating it out here.
Maybe @tOkeshu or @NiKo could pick this up on Monday.
User Story: (updated)
Priority: -- → P1
Target Milestone: --- → mozilla32
Dan convinced me that the UX around this area might change, so it would be worth waiting until we've got a better UX definition. I can manage bug 994151 slightly differently, so pushing this out to MVP.
Blocks: 972014
No longer blocks: 994151
Priority: P1 → P3
Target Milestone: mozilla32 → mozilla33
Assignee: nobody → nperriault
I'll just add a spinning wheel or something in the meanwhile, so the user has a sense that the operation is pending.
Attachment #8417425 - Flags: review?(dmose) → review+
Attachment #8417427 - Flags: review?(dmose) → review+
Landed gecko-dev patch onto loop-ui-initial: https://github.com/adamroach/gecko-dev/commit/323f7285bbc2161267a8db3cf5ea383a92a9135a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Verified fixed through previous smoketesting.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
QA Contact: anthony.s.hughes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: