1005107 - charsetMenu.properties not included in localized files

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Locale switching and selection, defect)

Description

[:Margaret Leibovic]

With bug 943262, we started using toolkit's CharsetMenu.jsm for the character encoding menu, and that pull strings from charsetMenu.properties. It appears that this file is not being localized on Fennec.

Bigger question: Why do the en-US strings work? If we want to avoid accidentally making mistakes like this, I think that something should break during the development process.

Comment 1

[:Margaret Leibovic]

Cc'ing Pike, since this is related to bug 792077.

Comment 2

[:Margaret Leibovic]

Attachment: Include charsetMenu.properties in localized files

I haven't made a multi-locale build to test this, but I just copied what we do for other toolkit files.

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 8422289 [details] [diff] [review]
Include charsetMenu.properties in localized files

Review of attachment 8422289 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, this looks right.

Comment 4

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/0041e151191b

Comment 5

[:Margaret Leibovic]

Comment on attachment 8422289 [details] [diff] [review]
Include charsetMenu.properties in localized files

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 943262 
User impact if declined: character encoding menu won't be localized
Testing completed (on m-c, etc.): just landed on fx-team
Risk to taking this patch (and alternatives if risky): adds a new toolkit locale file to our multi-locale build process
String or IDL/UUID changes made by this patch: adds new file to multi-locale build, but this file will already exist in desktop locales

Maybe Pike or flod can chime in about the l10n impact uplifting this would have, but AIUI this shouldn't cause a problem.

Comment 6

[Francesco Lodolo [:flod]]

From l10n point of view this change is welcome on aurora and beta: no new strings required, and we localize part of the UI. Just need to verify that everything works as expected on trunk.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0041e151191b

Comment 8

[Sylvestre Ledru [:Sylvestre]]

(In reply to Francesco Lodolo [:flod] from comment #6)
> Just need to verify that everything works as expected on trunk.
Let me know when we can uplift this patch to aurora & beta. Thanks

Comment 9

[Francesco Lodolo [:flod]]

Attachment: Nexus 7 screenshot

Menu is correctly localized in today's build.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9d058a45d893
https://hg.mozilla.org/releases/mozilla-beta/rev/51262a06149a

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/51262a06149a