1005213 - JS shell: 'options' function no longer returns prior options set

Status: RESOLVED DUPLICATE of bug 1000254

(Core :: JavaScript Engine, defect)

Description

[Jim Blandy :jimb]

Attachment: Make the JS shell 'options' function properly return the prior options set.

Bug 880330 (changeset e437294a2dbe) seems to have introduced a bug in the
JS shell's 'options' function, causing it to no longer return the previous
set of options. Many tests use 'options' like this:

    var oldOpts = options("werror");
    assertEq(oldOpts.indexOf("werror"), -1);

The code only appends option names to the result string if "!name", which
of course is never true if the strdup succeeds.

Comment 1

[Eddy Bruel [:ejpbruel]]

Comment on attachment 8416621 [details] [diff] [review]
Make the JS shell 'options' function properly return the prior options set.

Review of attachment 8416621 [details] [diff] [review]:
-----------------------------------------------------------------

I believe I wrote this code as part of the option flag refactor I did a while ago. Looks like I inverted the logic. Oops! Good catch!