Closed Bug 1005311 Opened 8 years ago Closed 8 years ago

[Building Blocks] warning in tabs.css

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S1 (9may)

People

(Reporter: dietrich, Assigned: kgrandon)

Details

(Whiteboard: [p=1],[systemsfe])

E/GeckoConsole( 4873): [JavaScript Warning: "Expected end of selector or a user action pseudo-class after pseudo-element but found '.'.  Ruleset ignored due to bad selector." {file: "app://sideloader.gaiamobile.org/shared/style/tabs.css" line: 230 column: 0 source: ".bb-tablist[data-type="filter"] > li > a[aria-selected="true"]:after,"}]
It seems like our CSS linter may not properly lint files from the shared/ folder. We should fix so it gets caught on travis to ensure we don't regress here.
Do you have a recent build? It appears that this was actually fixed recently: 

https://github.com/mozilla-b2g/gaia/commit/e1f273c6e28fc9a7d42bde9f6de43146457ad0fe#diff-85ef8d288b0f387823f6559da054b6efR229
Flags: needinfo?(dietrich)
We could always land this to update the error count. I guess our linter does check these files, but not sure why it failed here: https://github.com/mozilla-b2g/gaia/pull/18903
Let's close this as being fixed by the fix for bug 997084. Also landed my tiny patch to remove the line from xfail.list: https://github.com/mozilla-b2g/gaia/commit/48c19b3690a15979e3684956f3e7f91e0e1ad233
Assignee: nobody → kgrandon
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(dietrich)
Resolution: --- → FIXED
Whiteboard: [p=1],[systemsfe]
Target Milestone: --- → 2.0 S1 (9may)
You need to log in before you can comment on or make changes to this bug.