1005340 - [Home2] Offline Icon Handling

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Kevin Grandon :kgrandon]

We should make sure that we support all offline handling cases for icons. Currently we just display icons based on the http url that we can receive from the manifest or bookmark.

Comment 1

[Kevin Grandon :kgrandon]

Hi Cristian -

Just wondering if you could chime in with your expertise here. Right now we are just displaying a link to the image for icons, but I assume that we need to perform some downloading/saving of the image. Do you think it is necessary to process and save the image in IndexedDB for example?

Comment 2

[Cristian Rodriguez (:crdlc)]

Hi Kevin,

   The current implementation is based on a library called IconRetriever which deals with downloads (e.g. it retries when a timeout happens, waiting for downloading images when the device is offline, etc..). IMHO I think that once the icon is obtained you could save the image in IndexedDB in order to be faster rendering next time and also you do not need to consume more data getting remote images next times. I think that is the correct to way to proceed but it is just my opinion. Maybe I can be wrong.

Cheers

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/icon_retriever.js

Comment 3

[Cristian Rodriguez (:crdlc)]

I will try to do the first approach in order to help you in your awesome work in home2

Comment 4

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8417416 [details]
Patch v1

Hey Cristian, this is awesome! I made one nit on github which may result in some nicer syntax. If you can address that and fix the jshint issues on travis (just need some /* global ____ */ tags, I think we should be good to land.

Thanks so much for knocking this out :)

Comment 6

[Cristian Rodriguez (:crdlc)]

Thanks a lot Kevin, I gonna fix it immediately

Comment 7

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/cfc40f41bf417c2d242033fefd53b7aa3f3bf71c

Comment 8

[Kevin Grandon :kgrandon]

Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.