Closed Bug 1005340 Opened 6 years ago Closed 6 years ago

[Home2] Offline Icon Handling

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

x86
macOS
defect
Not set

Tracking

(feature-b2g:2.0, b2g-v2.0 fixed)

RESOLVED FIXED
2.0 S1 (9may)
feature-b2g 2.0
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: kgrandon, Assigned: crdlc)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

We should make sure that we support all offline handling cases for icons. Currently we just display icons based on the http url that we can receive from the manifest or bookmark.
Hi Cristian -

Just wondering if you could chime in with your expertise here. Right now we are just displaying a link to the image for icons, but I assume that we need to perform some downloading/saving of the image. Do you think it is necessary to process and save the image in IndexedDB for example?
Flags: needinfo?(crdlc)
Hi Kevin,

   The current implementation is based on a library called IconRetriever which deals with downloads (e.g. it retries when a timeout happens, waiting for downloading images when the device is offline, etc..). IMHO I think that once the icon is obtained you could save the image in IndexedDB in order to be faster rendering next time and also you do not need to consume more data getting remote images next times. I think that is the correct to way to proceed but it is just my opinion. Maybe I can be wrong.

Cheers

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/icon_retriever.js
Flags: needinfo?(crdlc)
I will try to do the first approach in order to help you in your awesome work in home2
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Attached file Patch v1
Attachment #8417416 - Flags: review?(kgrandon)
Comment on attachment 8417416 [details]
Patch v1

Hey Cristian, this is awesome! I made one nit on github which may result in some nicer syntax. If you can address that and fix the jshint issues on travis (just need some /* global ____ */ tags, I think we should be good to land.

Thanks so much for knocking this out :)
Attachment #8417416 - Flags: review?(kgrandon) → review+
Thanks a lot Kevin, I gonna fix it immediately
Merged in master:

https://github.com/mozilla-b2g/gaia/commit/cfc40f41bf417c2d242033fefd53b7aa3f3bf71c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 1006571
Whiteboard: [systemsfe]
Target Milestone: --- → 2.0 S1 (9may)
feature-b2g: --- → 2.0
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
You need to log in before you can comment on or make changes to this bug.