1005412 - file attachments have a bad timestamp

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: File attachments, defect)

Description

[Tomislav Jovanovic :zombie]

a developer is following Addon SDK "Getting Started" tutorial:

https://developer.mozilla.org/en-US/Add-ons/SDK/Tutorials/Getting_started

she uses wget to download the three icons, and they get the epoch 0 (1970) timestamp.

making the addon uses zip, which can't handle dates earlier than 1980, and they are stuck.

this has happened a few times already.

Comment 1

[Sean Coates]

FWIW, it's the `Last-Modified` that `wget` seems to use to set the ctime on the file:

$ curl -sIXGET https://mdn.mozillademos.org/files/7751/test-64.png | egrep '(Last|Date)'
Date: Sat, 03 May 2014 01:54:14 GMT
Last-Modified: Thu, 01 Jan 1970 00:00:00 GMT

Comment 2

[James Bennett [:ubernostrum]]

It looks like the problem here is with the way the files are stored. MDN has the necessary information, and can set the correct Last-Modified header, but MDN doesn't serve those files; the CDN does, and it sets Last-Modified based on criteria I'm unfamiliar with. Will investigate a bit and see if we can figure out a solution.

Comment 3

[Māris Fogels [:mars] (please needinfo)]

Marking as Major because this has consequences for application packaging.

Comment 5

[Will Bamberg [:wbamberg]]

I've added a note in the tutorial that I hope will help people who run into this problem: https://developer.mozilla.org/en-US/Add-ons/SDK/Tutorials/Getting_started.

Comment 6

[bugzilla.mozilla.org]

Yeah, also downloaded files with wget and running into that problem.

Comment 7

[Abhishek Mahadevan]

I'd like to work on this bug, seeing as it's still unresolved. Could anybody give me a hint as to where to begin?

Comment 8

[James Bennett [:ubernostrum]]

Actually, we'd need someone to verify that this is still a bug; as far as I'm able to tell, the fix in bug 968367 should also have fixed this.

Comment 9

[Luke Crouch [:groovecoder]]

Abhishek, can you verify the original bug?

Comment 10

[Abhishek Mahadevan]

Luke, I did not experience the error in question myself. I assumed it might be a good first bug for me.

Comment 11

[Sean Coates]

FWIW, this seems to be fixed now:

$ curl -sIXGET https://mdn.mozillademos.org/files/7751/test-64.png | egrep '(Last|Date)'
Date: Fri, 02 Jan 2015 21:16:17 GMT
Last-Modified: Sat, 03 May 2014 01:01:18 GMT

Comment 12

[C. Liang [:cyliang]]

I currently can not reproduce the error.  (See my attempt below.)  If someone *can* reproduce the error, please provide output so we can start digging into the problem. =)

$ wget -S https://mdn.mozillademos.org/files/7637/icon-32.png
--2015-01-02 16:25:43--  https://mdn.mozillademos.org/files/7637/icon-32.png
Resolving mdn.mozillademos.org (mdn.mozillademos.org)... 63.245.215.74
Connecting to mdn.mozillademos.org (mdn.mozillademos.org)|63.245.215.74|:443... connected.
HTTP request sent, awaiting response...
  HTTP/1.1 200 OK
  Server: Apache
  X-Backend-Server: developer1.webapp.scl3.mozilla.com
  X-Backend-Server: developer1.webapp.scl3.mozilla.com
  Vary: Cookie
  Content-Type: image/png
  Access-Control-Allow-Credentials: false
  Date: Fri, 02 Jan 2015 21:19:33 GMT
  Keep-Alive: timeout=5, max=999
  Access-Control-Allow-Origin: *
  Accept-Ranges: bytes
  X-Frame-Options: ALLOW-FROM: developer.mozilla.org
  Last-Modified: Tue, 08 Apr 2014 22:48:49 GMT
  Access-Control-Allow-Methods: GET
  Content-Length: 3457
  Connection: Keep-Alive
  X-Cache-Info: cached
Length: 3457 (3.4K) [image/png]
Saving to: ‘icon-32.png’

100%[======================================>] 3,457       --.-K/s   in 0s

2015-01-02 16:25:43 (366 MB/s) - ‘icon-32.png’ saved [3457/3457]

[cliang@fc ~]$ ls -lad icon-32.png
-rw-rw-r--. 1 cliang cliang 3457 Apr  8  2014 icon-32.png

Comment 13

[Luke Crouch [:groovecoder]]

Thanks all, I'll mark this as fixed.

Abhishek - is there another bug in https://wiki.mozilla.org/Webdev/GetInvolved/developer.mozilla.org#Mentored_Bugs that interests you?

Comment 14

[Sean Coates]

The "You might see an error message" note here (https://developer.mozilla.org/en-US/Add-ons/SDK/Tutorials/Getting_started) can be removed now.