1005418 - Out-of-order timestamps in H.264 NAL jitter adjustment

Status: RESOLVED DUPLICATE of bug 985254

(Core :: WebRTC: Audio/Video, defect)

Description

[Eric Rescorla (:ekr)]

Attachment: 0001-Fix-for-nal-timestamp-adjustment.patch

Bug 1002402 applied jitter to SPS and PPS packets in order to avoid them being subject to duplicate suppression. Unfortunately, the way that the jitter is applied results in the PPS packets (which are sent second) having a timestamp prior to the SPS packets. The following patch probably isn't quite what we want but should get the timestamps in the right order.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8416844 [details] [diff] [review]
0001-Fix-for-nal-timestamp-adjustment.patch

Review of attachment 8416844 [details] [diff] [review]:
-----------------------------------------------------------------

An improvement until we can solve the underlying bug via the packetization work (tested and fixes initial green-screen and reduces total delay until we see video)

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

I'll note that SPS and PPS can come in any order in theory (IIRC)

Comment 3

[Eric Rescorla (:ekr)]

In that case, we should probably instead modify the timestamps in the order
things appear in the packet.

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

This is a bug in the original checkin, but will soon become moot with the patches for H.264 packetization in bug 985254