1005456 - fails to make win32 build .zip package unless all versions of d3c are found

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Alice0775 White]

I was using windows 7 SDK, June 2010 DirectX SDK, Visual Studio 2010 Express and MozillaBuild 1.8. 
And I tried to build from http://hg.mozilla.org/integration/mozilla-inbound/ repository.

pymake -f client.mk build successfully performed, and bin/firefox.exe successfully ran without error. 
However,
pymake -C ff-dbg/browser/installer fails to make .zip package.

Last good: 728803659bcb
First bad: 8b48386fc226
Regressed by:
8b48386fc226	Jeff Gilbert — Bug 999260 - Ship both d3dcompiler_43 and _46+. - r=mshal

Comment 1

[Alice0775 White]

Attachment: .mozconfig

Comment 2

[Masatoshi Kimura [:emk]]

Me too. I'm using Win8.1 SDK, VS 2013 and MozillaBuild 1.9 without --disable-gamepad.
mach build installer failed with the patch and succeeds without the patch.

Last good: f1f88dcc871d
First bad: 8b48386fc226

Comment 3

[Masatoshi Kimura [:emk]]

package-manifest had an invalid entry:
---
bin/libGLESv2.dll

bin/d3dcompiler_47.dll

bin/

; [Browser Chrome Files]
---
Looks like MOZ_D3DCOMPILER_VISTA_DLL or MOZ_D3DCOMPILER_XP_DLL is always defined even if it is empty.

Comment 4

[Alice0775 White]

Attachment: log.zip

log.txt: output logged from the following command.

$ /c/mozilla-build1_8/hg/hg clone http://hg.mozilla.org/integration/mozilla-inbound/ /d/srcinbound

$ cd /d/srcinbound

$ alias pymake=d:/srcinbound/build/pymake/make.py

$ /c/mozilla-build1_8/hg/hg revert --all -r 8b48386fc226

$ pymake -f client.mk build

$ pymake -C ff-dbg/browser/installer

Comment 5

[Alice0775 White]

Oops, Sorry, paste error in comment#0:
> Last good: 728803659bcb
> First bad: 8b48386fc226

Correct:
Last good: f1f88dcc871d
First bad: 8b48386fc226

Comment 6

[Masatoshi Kimura [:emk]]

Attachment: Stop generating an invalid package-manifest when only one d3dc version was found

Alice, does this patch solve your issue?
(You don't have to rebuild again, just execute pymake -C ff-dbg/browser/installer again.)

Comment 7

[Masatoshi Kimura [:emk]]

(In reply to Masatoshi Kimura [:emk] from comment #6)
> (You don't have to rebuild again, just execute pymake -C
> ff-dbg/browser/installer again.)

Ah, wait, you will have to regenerate Makefile. But I forget how to regenerate Makefile without mach...

Comment 8

[Alice0775 White]

(In reply to Masatoshi Kimura [:emk] from comment #6)
> Created attachment 8416879 [details] [diff] [review]
> Stop generating an invalid package-manifest when only one d3dc version was
> found
> 
> Alice, does this patch solve your issue?
> (You don't have to rebuild again, just execute pymake -C
> ff-dbg/browser/installer again.)

I built win32 build again with attachment 8416879 [details] [diff] [review].
attachment 8416879 [details] [diff] [review] fixes this problem. :)

Comment 9

[Masatoshi Kimura [:emk]]

Comment on attachment 8416879 [details] [diff] [review]
Stop generating an invalid package-manifest when only one d3dc version was found

Thanks to the confirmation. Requesting a review.

Comment 10

[Mark Hammond [:markh] [:mhammond]]

I've recently started getting a similar issue:

 0:49.42 cp: cannot stat `C:\\Program Files (x86)\\Microsoft SDKs\\Windows\\v7.0A\\/Redist/D3D/x86/d3dcompiler_46.dll': No such file or directory
 0:49.42 mozmake.EXE[5]: *** [libs] Error 1
 0:49.42 o:/src/mozilla-git/gecko-dev/config/recurse.mk:95: recipe for target 'gfx/angle/libs' failed
 0:49.42 mozmake.EXE[4]: *** [gfx/angle/libs] Error 2
 
The attachment does not fix the problem for me.

Comment 11

[Masatoshi Kimura [:emk]]

(In reply to Mark Hammond [:markh] from comment #10)
> I've recently started getting a similar issue:
> 
>  0:49.42 cp: cannot stat `C:\\Program Files (x86)\\Microsoft
> SDKs\\Windows\\v7.0A\\/Redist/D3D/x86/d3dcompiler_46.dll': No such file or
> directory
>  0:49.42 mozmake.EXE[5]: *** [libs] Error 1
>  0:49.42 o:/src/mozilla-git/gecko-dev/config/recurse.mk:95: recipe for
> target 'gfx/angle/libs' failed
>  0:49.42 mozmake.EXE[4]: *** [gfx/angle/libs] Error 2
>  
> The attachment does not fix the problem for me.

That's bug 1005484.

Comment 12

[Masatoshi Kimura [:emk]]

Mark, could you answer the question from bug 1005484 comment 5?

Comment 13

[Mark Hammond [:markh] [:mhammond]]

(In reply to Masatoshi Kimura [:emk] from comment #12)
> Mark, could you answer the question from bug 1005484 comment 5?

Upgrading mozbuild fixed the problem for me.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d5ee95d4e54

Thanks for fixing this, emk! I was just going to file the same bustage when I found this bug.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4d5ee95d4e54