Closed Bug 1005473 Opened 12 years ago Closed 11 years ago

Hitting F3 to get to the next result when searching in Scratchpad does nothing

Categories

(DevTools Graveyard :: Scratchpad, defect)

Product:
DevTools Graveyard
Component:
Scratchpad
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1011504

People

(Reporter: elbart, Unassigned)

References

Details

Affected: 27.0 and newer Addons using the same editor, i.e. Greasemonkey and Stylish. Not affected: 24ESR STR: - Press Shift+F4 (opens Scratchpad) - Press Ctrl+F (opens Find-dialog) and enter "inspect" (without quotes) - Press F3 to go to the second "inspect" in the placeholder-text ER: Selection/focus switches to the second found instance of "inspect" in the same line as the first. AR: Nothing happens. Regression window: m-c: Last good revision: f97307cb4c95 (2013-09-23) First bad revision: 1fda74e33e06 (2013-09-24) Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f97307cb4c95&tochange=1fda74e33e06 m-i: Last good revision: 172a383a56a7 First bad revision: be8258aa5130 Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=172a383a56a7&tochange=be8258aa5130 Suspect: 8db3d638ccd1 Anton Kovalyov — Bug 912260 - Make Scratchpad use CodeMirror. r=robcee r=msucan
Blocks: 816756, 912260
Look at the keyboard shortcut for the Edit -> Find Again menu item, I believe that you will find it is Ctrl-G, not F3. At least that's what I see on Mac and Linux. I agree that the behavior here should be platform-specific though.
Status: UNCONFIRMED → NEW
Ever confirmed: true
No idea if it's platform-specific, but Scratchpad is now the only place, as far as I noticed, where F3 doesn't work anymore.
Apparently this was fixed upstream a few weeks ago: https://github.com/marijnh/CodeMirror/pull/2380
Oh, sorry, that's using Ctrl+F3, not F3 by itself. So it's not fixed there either.
Are we gonna have F3 for FindNext in Scratchpad too, besides Ctrl-G, to make in consistent with other windows? If no, can we close this issue? If yes, I would be happy to submit a patch.
Flags: needinfo?(past)
This now works on both Linux and Mac, but I'm not sure which patch fixed it.
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(past)
Resolution: --- → WORKSFORME
Bug 1011504, I guess.
Resolution: WORKSFORME → DUPLICATE
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.