1005475 - Remove lock acquire from CacheEntry::IsFileDoomed()

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Honza Bambas (:mayhemer)]

Michal, you didn't address my review request on this at https://bugzilla.mozilla.org/show_bug.cgi?id=913808#c26.

Comment 1

[Honza Bambas (:mayhemer)]

Attachment: v1

Comment 2

[Honza Bambas (:mayhemer)]

Regarding CacheFile::IsDoomed() - mHandle to my knowledge will never go away, right?  CacheFileHandle::IsDoomed() reads an aligned bool, so it's thread-safe.  I think that CacheFile::IsDoomed() doesn't need to lock as well.

Comment 3

[Honza Bambas (:mayhemer)]

Attachment: v2 (more aggressive)

Based on comment 2.

Comment 4

[Honza Bambas (:mayhemer)]

https://tbpl.mozilla.org/?tree=Try&rev=9dd5d47cb23d (try -a)
https://tbpl.mozilla.org/?tree=Try&rev=6f3980478258 (talos, compare to reference 5c379a4d7577)

Comment 5

[Honza Bambas (:mayhemer)]

Comment on attachment 8416904 [details] [diff] [review]
v1

In case of a direct load (truncate or memory-only) mFile can be for a short time null after mFileStatus is set to NS_OK.  Those assignments must happen in different order.

Comment 6

[Honza Bambas (:mayhemer)]

Attachment: v3

https://tbpl.mozilla.org/?tree=Try&rev=d3dcea2411ef (try -a)

Comment 8

[Honza Bambas (:mayhemer)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f9fb2d2f4ac

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0f9fb2d2f4ac