1005510 - Keyboard shortcut CTRL+D [add bookmark] not working with Norwegian [nb-NO] locale

Status: RESOLVED FIXED

(Mozilla Localizations :: nb-NO / Norwegian Bokmål, defect)

Description

[Øyvind Stegard]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140428193813

Steps to reproduce:

Tried to bookmark a page by pressing CTRL+D. 


Actual results:

Nothing.

Then noticed "Bookmark this page" had been assigned "CTRL+R" in menu and tried that, but page reloaded instead.


Expected results:

The keyboard shortcut CTRL+D to bookmark current page does not work with Norwegian locale.

Instead it looks like "Bookmark this page" is set to CTRL+R, but that clashes with the page reload shortcut, which seems to take precedence. The conflict seems to be introduced by the following change:

http://hg.mozilla.org/releases/l10n/mozilla-release/nb-NO/rev/9231bd6e8360

Specifically this:
    1.78  <!ENTITY bookmarkThisPageCmd.label "Bokmerk denne siden">
    1.79 -<!ENTITY bookmarkThisPageCmd.commandkey "d">
    1.80 +<!ENTITY editThisBookmarkCmd.label "Rediger dette bokmerket">
    1.81 +<!ENTITY bookmarkThisPageCmd.commandkey "R">
    1.82  <!ENTITY markPageCmd.commandkey "l">

Where commandkey is set to "R". IMO, this is not a good mnemonic for adding or editing a bookmark, and there should be a good reason for changing CTRL+D, which has been there a long time and is also documented here:
https://support.mozilla.org/no/kb/keyboard-shortcuts-perform-firefox-tasks-quickly#w_bookmarks

Comment 1

[Øyvind Stegard]

Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0

Comment 2

[Håvar I. Henriksen [:havarh]]

I can confirm this on both Linux, OS X and Windows.
I guess what has happened here is that the "commandkey" string has been mistaken for the "accesskey" string. We never change the "commandkey" string on l10n work, only the "accesskey" string.

Comment 3

[Håvard Mork]

Fixed on beta in http://hg.mozilla.org/releases/l10n/mozilla-beta/nb-NO/rev/0b87fede3e25

Thanks for reporting.