1005567 - [css-grid] Remove grid-auto-position

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[Mats Palmgren (inactive)]

Attachment: fix

https://tbpl.mozilla.org/?tree=Try&rev=85f99722db04

Comment 2

[Simon Sapin (:SimonSapin)]

Comment on attachment 8416973 [details] [diff] [review]
fix

Review of attachment 8416973 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, except:

::: layout/style/test/property_database.js
@@ +5176,5 @@
>  			"grid-row-end"
>  		],
>  		initial_values: [ "auto", "auto / auto" ],
> +		other_values: gridLineOtherValues,
> +		invalid_values: gridLineInvalidValues

This (and above for grid-column) is removing tests that should not be removed (i.e. values with two explicit <grid-line>s.) Please keep gridColumnRowOtherValues and gridColumnRowInvalidValues with the same content as before, maybe pushing to them directly without the (now unused) gridAutoPosition* intermediate variables.

Comment 3

[Mats Palmgren (inactive)]

Attachment: fix

Good catch, thanks.  Is this what you suggested?  I dropped the "foo"
in the array - I suppose that's what the splice removed?

Looks green (the orange is unrelated):
https://tbpl.mozilla.org/?tree=Try&rev=ee4f50ddd48f

Comment 4

[Simon Sapin (:SimonSapin)]

Comment on attachment 8417848 [details] [diff] [review]
fix

Review of attachment 8417848 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 5

[Mats Palmgren (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7f715a1d5b28

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7f715a1d5b28

Comment 7

[Kohei Yoshino [:kohei]]

This is still disabled by default, won't affect site compat.