Closed Bug 1005578 Opened 5 years ago Closed 5 years ago
Standard URL::Set Host called net _To Lower Case with a bogus pointer, #2
304 bytes, text/html
10.92 KB, text/plain
773 bytes, patch
|Details | Diff | Splinter Review|
Same symptoms as bug 991471, different testcase.
Crash Signature: [@ net_ToLowerCase(char*, unsigned int) ]
According to the spec, we should discard the old url object when calling url.href http://url.spec.whatwg.org/#concept-uu-set-the-input
Assignee: nobody → valentin.gosu
Status: NEW → ASSIGNED
Attachment #8417035 - Flags: review?(bzbarsky)
Comment on attachment 8417035 [details] [diff] [review] url_crash.patch Yeah, makes sense.
Attachment #8417035 - Flags: review?(bzbarsky) → review+
Comment on attachment 8417035 [details] [diff] [review] url_crash.patch [Security approval request comment] How easily could an exploit be constructed based on the patch? The changes made in the patch don't immediately reveal the vulnerability. It would be very difficult to create an exploit based on this patch. Do comments in the patch, the check-in comment, or tests included in the patch paint a bulls-eye on the security problem? The comment does say what the problem is, and it might need to be changed. Which older supported branches are affected by this flaw? All branches are affected. Do you have backports for the affected branches? If not, how different, hard to create, and risky will they be? It should be easy to apply this patch on all branches. How likely is this patch to cause regressions; how much testing does it need?
Attachment #8417035 - Flags: sec-approval?
(In reply to Valentin Gosu [:valentin] from comment #5) > How likely is this patch to cause regressions; how much testing does it need? Unlikely. Not a risky change, and it is the specified behavior in the spec.
Comment on attachment 8417035 [details] [diff] [review] url_crash.patch sec-approval+ for trunk. Please create Aurora, Beta, and ESR24 patches and nominate them once it is in trunk.
Attachment #8417035 - Flags: sec-approval? → sec-approval+
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ffa88afe433 Please request Aurora/Beta/ESR24 approval on this ASAP to expedite it being uplifted everywhere else it needs to go.
It seems I misread the output of hg log, and that the error was actually introduced by http://hg.mozilla.org/mozilla-central/rev/f2199d73aef6 ESR24 is not affected.
Comment on attachment 8417035 [details] [diff] [review] url_crash.patch [Approval Request Comment] Issue caused by (bug #): Bug 887364 User impact if declined: Security concerns Testing completed (on m-c, etc.): on m-c Risk to taking this patch (and alternatives if risky): low String or IDL/UUID changes made by this patch: none
Comment on attachment 8417035 [details] [diff] [review] url_crash.patch Valentin, don't hesitate to be a bit more verbose next time ;)
(In reply to Sylvestre Ledru [:sylvestre] from comment #11) > Valentin, don't hesitate to be a bit more verbose next time ;) Thanks! I will :)
Confirmed crash on 2014-04-21, debug build of Fx30. Verified fixed 2014-06-03, ASan builds of Fx30, Fx31 and Fx32.
Applied ontop of a relbranch for SeaMonkey 2.26.1 (Gecko 29 based): https://hg.mozilla.org/releases/mozilla-release/rev/908f619b9122
You need to log in before you can comment on or make changes to this bug.