1005663 - Restoring tabs from last session causes reopening of closed popups

Status: RESOLVED DUPLICATE of bug 495123

(Firefox :: Session Restore, defect)

Description

[pietro.brenna]

Attachment: Simple & stupid testcase

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140430131441

Steps to reproduce:

0. Enable "Restore tabs & windows from last session" setting
1. Open a popup from a web page (such as the simple attached);
2. close the popup
3. in the main window, open new tab (about:newtab) and close all other tabs
4. with only the about:newtab open, close firefox
5. open firefox


Actual results:

1. The main window contained a tab displaying the page opened in the popup
2. in addition the popup was reopened


Expected results:

Have firefox open with about:newtab in the main window

Comment 1

[Paul Silaghi, QA [:pauly]]

Reproduced in FF 29, but not in latest nightly 32.0a1 (2014-05-06), Win 7 x64.

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Paul, is this a problem in FF 30?

Comment 3

[Paul Silaghi, QA [:pauly]]

Yes, FF 30b2

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Thanks! I guess we should investigate this then given that Beta is affected. I was asking because I assume this isn't an issue we would consider for a possible 29.0.1.

Comment 5

[Paul Silaghi, QA [:pauly]]

Also not repro on 31.0a2 (2014-05-07)

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

We should try to find an inverted regression range first, basically to find what fixed it for 31.

Comment 7

[Paul Silaghi, QA [:pauly]]

This bug is a regression between FF 23 and FF 24.

And it was fixed by something in this list:
Last bad nightly: 2014-03-27
First good nightly: 2014-03-28
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=441f5fd256e2&tochange=6fa163ff81a3

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

Thanks Paul, that was fast :) Looks like bug 495123. Can you also find out what 31 Nightly fixed it?

Comment 9

[Paul Silaghi, QA [:pauly]]

(In reply to Tim Taubert [:ttaubert] from comment #8)
> Can you also find out what 31 Nightly fixed it?
I think bug 495123 actually fixed it.

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

Ok, now I know what's going on. This is a dupe of bug 495123. Bug 495123 was fixed starting 31 and we didn't uplift it because it has been around for quite long anyway. Good to know it's not another regression.

Comment 11

[Tim Taubert [:ttaubert] (inactive)]

Thanks for all your help, Paul!

Comment 12

[Paul Silaghi, QA [:pauly]]

Anytime, Tim.