1005677 - Pocket / reading list icon breaks panel layout

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Alexandre Magno]

Attachment: firefox-panel-bug-none.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140428194100

Comment 1

[Alexandre Magno]

Attachment: firefox-panel-bug-confuse.png

Comment 2

[:Gijs (he/him)]

Jorge, do you know if we have contacts for the pocket developers, and/or if the pocket part of this is a duplicate?

Alexandre: all the issues are with add-on buttons, as far as I can tell from the screenshot. There's not a lot Firefox can do about the issues those buttons are causing. :-(

Comment 3

[Alexandre Magno]

The red words "None" were painted by me.
The red characters '?' were painted by me.

Comment 4

[Alexandre Magno]

Attachment: firefox-panel-bug-empty.png

When I empty the panel...

Comment 5

[:Gijs (he/him)]

(In reply to Alexandre Magno from comment #4)
> Created attachment 8418307 [details]
> firefox-panel-bug-empty.png
> 
> When I empty the panel...

It looks like there is still something in there, like a spacer or separator. What does running the following in the browser console (ctrl+shift+j) return:

CustomizableUI.getWidgetIdsInArea("PanelUI-contents").join(',')

?

Comment 6

[Alexandre Magno]

< CustomizableUI.getWidgetIdsInArea("PanelUI-contents").join(',')
> "customizableui-special-spacer15"

Comment 7

[:Gijs (he/him)]

(In reply to Alexandre Magno from comment #6)
> < CustomizableUI.getWidgetIdsInArea("PanelUI-contents").join(',')
> > "customizableui-special-spacer15"

Grand. You can fix it by running:

CustomizableUI.removeWidgetFromArea("customizableui-special-spacer15");

We're tracking fixing this generally in bug 1003588.

Comment 8

[Alexandre Magno]

OK. Thanks. Part of the problem was resolved. The Pocket continues wrong...

Comment 9

[Jorge Villalobos [:jorgev] (he/him)]

I installed Pocket and didn't see any problems, having it in the main toolbar or the menu panel. How was Pocket identified as the problem here, given the rather large amount of add-on icons I see in the screenshots?

Comment 10

[:Gijs (he/him)]

(In reply to Jorge Villalobos [:jorgev] from comment #9)
> I installed Pocket and didn't see any problems, having it in the main
> toolbar or the menu panel. How was Pocket identified as the problem here,
> given the rather large amount of add-on icons I see in the screenshots?

Because in attachment 8417062 [details], it is clearly wider than the other icons, and causing the developer tools to shift right, and the third icon to no longer fit.

It's possible that a pocket update resolved this, or that the issue is specific to a certain OS / font size.

Comment 11

[Alexandre Magno]

> How was Pocket identified as the problem here, given the rather large amount of add-on icons I see in the screenshots?

When it is added at panel, the panel breaks the sequence. But it isn't I who rewritten the bug's title.

Comment 12

[Alexandre Magno]

The shape of the Pocket's button is unlike any other.

Comment 13

[Jorge Villalobos [:jorgev] (he/him)]

Ah, I see now. I moved it to the one place where it didn't break the layout. I'll notify the developers.

Comment 14

[Michael Ellis]

Jorge - Can we close this bug now?

Comment 15

[Jorge Villalobos [:jorgev] (he/him)]

Yes, I think this was fixed long ago.