Closed
Bug 1005679
Opened 11 years ago
Closed 11 years ago
Remove cruft from the viewLog dialog and and bring it up to spec.
Categories
(MailNews Core :: Filters, defect)
MailNews Core
Filters
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 32.0
People
(Reporter: philip.chee, Assigned: philip.chee)
References
()
Details
Attachments
(1 file)
If you have never turned on the filter log (or cleared the log) and you look at the View Log window all you'll see is a grey tabula rasa. I was working on another bug so I was never sure if my filters weren't working or they were but the view log window was broken. And as it currently stands it doesn't match the spec at: http://www-archive.mozilla.org/mailnews/specs/filters/#Log
I intend to do some housekeeping and remove some unnecessary bits and do some minor polish.
|
Assignee | |
Comment 1•11 years ago
|
||
> --- a/mailnews/base/content/junkLog.xul
> +++ b/mailnews/base/content/junkLog.xul
The Junk Log and View Log windows could be twins separated at birth or something.
> + <browser id="logView"
> + class="inset"
Inset look as per spec.
> + type="content"
This browser shouldn't give chrome privileges to it's content.
> + disablehistory="true"
> + disablesecurity="true"
> + src="about:blank"
> + autofind="false"
> + flex="1"/>
> -#define LOG_HEADER "<head><meta http-equiv=\"Content-Type\" content=\"text/html; charset=utf-8\"></head>"
> +#define LOG_HEADER "<head><meta http-equiv=\"Content-Type\" content=\"text/html; charset=utf-8\"><style type=\"text/css\">body{font-family:Consolas,\"Lucida Console\",Monaco,\"Courier New\",Courier,monospace;font-size:small}</style></head>"
Based on the Monospace stack from <http://css-tricks.com/snippets/css/font-stacks/>
/* Monospace stack */
font-family: Consolas, "Andale Mono WT", "Andale Mono", "Lucida Console", "Lucida Sans Typewriter", "DejaVu Sans Mono", "Bitstream Vera Sans Mono", "Liberation Mono", "Nimbus Mono L", Monaco, "Courier New", Courier, monospace;
Attachment #8417067 -
Flags: review?(mconley)
Attachment #8417067 -
Flags: review?(iann_bugzilla)
Attachment #8417067 -
Flags: feedback?(richard.marti)
Attachment #8417067 -
Flags: feedback?(josiah)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8417067 [details] [diff] [review]
Patch v1.0 Proposed fix.
UI wise this looks a lot better.
Attachment #8417067 -
Flags: feedback?(richard.marti) → feedback+
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8417067 [details] [diff] [review]
Patch v1.0 Proposed fix.
Review of attachment 8417067 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me, and the code seems fine.
Attachment #8417067 -
Flags: feedback?(josiah) → feedback+
Comment on attachment 8417067 [details] [diff] [review]
Patch v1.0 Proposed fix.
>+++ b/mailnews/base/search/content/viewLog.xul
> <checkbox id="logFilters" oncommand="toggleLogFilters()" label="&enableLog.label;" accesskey="&enableLog.accesskey;"/>
Missing ; from oncommand, could also have one parameter like now elsewhere in the file and maybe consistency of ordering too with oncommand last.
> <spacer flex="1"/>
> <button label="&clearLog.label;" accesskey="&clearLog.accesskey;" oncommand="clearLog()"/>
Missing ; from oncommand, could also have one parameter like now elsewhere in the file.
r=me
Attachment #8417067 -
Flags: review?(iann_bugzilla) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/c848885fb654
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 32.0
|
||
Comment 6•11 years ago
|
||
Comment on attachment 8417067 [details] [diff] [review]
Patch v1.0 Proposed fix.
Given this landed a while ago, I'm guessing the review request is no longer needed. If it is, please re-request with an explanation as to why.
Attachment #8417067 -
Flags: review?(mconley)
You need to log in
before you can comment on or make changes to this bug.
Description
•