Closed Bug 1005696 Opened 11 years ago Closed 11 years ago

TEST-UNEXPECTED-FAIL | test_bug455906.js | test failed + "false,false,false" == "true,true,false"

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33
Tracking Status
firefox31 --- wontfix
firefox32 --- fixed
firefox33 --- fixed
firefox-esr24 --- unaffected
firefox-esr31 --- fixed

People

(Reporter: mkmelin, Assigned: billm)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=39000438&tree=Thunderbird-Trunk&full=1 TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/test_bug455906.js | "false,false,false" == "true,true,false" - See following stack: JS frame :: C:/slave/test/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/test_bug455906.js :: check_test_pt1/< :: line 301 JS frame :: C:/slave/test/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/head_addons.js :: callback_soon/</< :: line 1536 JS frame :: C:\\slave\\test\\build\\xpcshell\\head.js :: do_execute_soon/<.run :: line 554 JS frame :: C:\\slave\\test\\build\\xpcshell\\head.js :: _do_main :: line 176 JS frame :: C:\\slave\\test\\build\\xpcshell\\head.js :: _execute_test :: line 389 JS frame :: -e :: <TOP_LEVEL> :: line 1 native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 -> http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/mozapps/extensions/test/xpcshell/test_bug455906.js#301
Might want to clobber - that happened once on mozilla-central, on an unclobbered build where it happened on all three Windows flavors, then once on mozilla-inbound, also on an unclobbered build, and hasn't (so far) happened again after I clobbered. I blame something that merged from fx-team, without actually being willing to look for what it might have been.
Component: General → Add-ons Manager
Product: Thunderbird → Toolkit
Interestingly, the patches for bug 996061 make this error perma-orange.
Actually, when I build locally (on windows 7), this fails for me on vanilla mozilla-central.
Attached patch addon-mgr-fixSplinter Review
I was also running into this and it reproduces for me locally. There are a number of tests that do this: http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/test/xpcshell/test_bug455906.js#248 That is, they put a new blocklist.xml in the profile directory. The problem with this is that there's code in the add-on manager that can overwrite the blocklist in the profile dir: http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/AddonManager.jsm#600 The decision whether to overwrite is based on the modification time of blocklist.xml. The copyTo function is Windows seems to set the destination file's modification date equal to the source file's modification date. So the test will fail if the blocklist file for the test (which is stored somewhere in tests.zip) is older than the date that's in the app blocklist.xml (which is presumably generated at build time). I don't know exactly when that could happen, but it's actually very likely on a developer machine. Anyway, an easy fix is to update the lastModifiedDate of the blocklist file after the copyTo operation. That's what I've done here.
Assignee: nobody → wmccloskey
Attachment #8443771 - Flags: review?(bmcbride)
Comment on attachment 8443771 [details] [diff] [review] addon-mgr-fix Review of attachment 8443771 [details] [diff] [review]: ----------------------------------------------------------------- Oh, nice catch!
Attachment #8443771 - Flags: review?(bmcbride) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: