1005800 - [NFC] Long press home button still can work while NFC is pairing

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Alison Shiue]

+++ This bug was initially created as a clone of Bug #997595 +++

most up-to-date pvt build 2014/4/16 

STR:
1. launch "settings" app for 2 phones
2. turn on "NFC" for 2 phones
3. launch "browser" from phone A
4. tap 2 phones
5. long press home button on phone A when shrinking UI shows up

Expected result:
Home button should block all functions while NFC is pairing

Actual result:
Long press home button still can kill processes, once kill browser app, tap 2 phones still cause them to pair(vibrate)

===============================================================
Verified on:
Gaia      f55fc5c507312c7aac51ec9bb73061fd4ed5c5fb
Gecko     https://hg.mozilla.org/mozilla-central/rev/3285e030d9c0
BuildID   20140504160202
Version   32.0a1

Long press home button still works when NFC is pairing.

Comment 1

[howie [:howie]]

2.0 feature not blocking

Comment 2

[[e-mail]]

The issue happens because CardsView got `holdhome` event before ShrinkingUI, so the CardsView event handler is still triggered.

Which is preferred approach, to reorder event receiving(?) or check ShrinkingUI stat in CardsView?

Comment 3

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

re-nominate. IMO, this is more like a defect of already-landed feature.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Fred Lin [:gasolin] from comment #2)
> The issue happens because CardsView got `holdhome` event before ShrinkingUI,
> so the CardsView event handler is still triggered.
> 
> Which is preferred approach, to reorder event receiving(?) or check
> ShrinkingUI stat in CardsView?

CardsView should not depends on ShrinkingUI. ShrinkingUI is for NFC-device only but CardsView is for every device. please reorder it.

I suggest to wait https://bugzilla.mozilla.org/show_bug.cgi?id=935260 landed.

Comment 5

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Propose to have this fixed in sprint3, as per comment 4 we should wait for bug 935260 which is in sprint2.
Feel free to modify the target milestone if this doesn't work.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Fred, are you still actively working on this bug?

Comment 7

[[e-mail]]

No, since the blocking bug landed, I'll start work on it next week

Comment 8

[[e-mail]]

Attachment: pull request redirect to github

tested on real device

Comment 9

[[e-mail]]

The approach:
In order to receive `holdhome` event first, move nfc import in front of task manager import in index.html

Comment 10

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/26db7621deaa6851be4da3c5e67c9ac09420a106

thanks!

Comment 11

[Alison Shiue]

Verified on 
Gaia      bc6f07c149770c6e6dfbea941ac65138dc364a15
Gecko     https://hg.mozilla.org/mozilla-central/rev/e017c15325ae
BuildID   20140528040205
Version   32.0a1

Comment 12

[Mike Lien[:mlien]]

verify with Flame v180 + v2.0 gaia/gecko, it's fine
Gaia      7edd3b0b9f65c3dde235c732d270e43e055a1254
Gecko     https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/f3639e825b3b
BuildID   20140915135336
Version   32.0