1005855 - Arrows in Bookmarks Menu are flipped (RTL locale)

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[eldada333]

Attachment: Bug Screenshot

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140421221237

Steps to reproduce:

* Click on the bookmarks icon in the toolbar.


Actual results:

The sub-menu arrows are flipped.


Expected results:

The arrows shouldn't have been flipped.

Comment 1

[Tomer Cohen :tomer]

Attachment: Screenshot (Linux)

I can reproduce this problem on Linux as well. 

Steps to reproduce:

0. Get a clean copy of Firefox with RTL UI.
1. Click the bookmarks menu.

Current result:
Arrow pointing inside (pointing to the text)

Expected result:
Arrows should point outside. This is probably a regression caused by Australis.

Comment 2

[:Gijs (he/him)]

Is this still broken on trunk as well?

Comment 3

[Tomer Cohen :tomer]

(In reply to :Gijs Kruitbosch from comment #2)
> Is this still broken on trunk as well?

On Aurora it reproduce as well. Not tested on nightly as it is a bit more difficult, because there is no localized or RTL builds on nightly.

Comment 4

[Aleksandr Seleznev]

Attachment: Patch

I tested it on Linux with AR locale.

---

Bad commit: http://hg.mozilla.org/mozilla-central/rev/03e7402f6fd3

On MacOS it should works fine because we already have "transform: scaleX(-1);"
in "./toolkit/themes/osx/global/menu.css" [1]. However, I can't test it. :(

1: https://mxr.mozilla.org/mozilla-central/source/toolkit/themes/osx/global/menu.css#101

Comment 5

[Aleksandr Seleznev]

Attachment: Screenshot (Linux, with patch)

Comment 6

[:Gijs (he/him)]

Comment on attachment 8473887 [details] [diff] [review]
Patch

Review of attachment 8473887 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks for the patch! (sorry for the review delay, I was on holiday)

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/83e0106a94d4

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/83e0106a94d4

Comment 9

[Andrei Vaida [:avaida]]

Verified fixed on Nightly 34.0a1 (2014-08-28), using Windows 7 64-bit, Ubuntu 14.04 LTS 64-bit and Mac OS X 10.9.4 with the following locales: ar, fa, he and also with a rtl-forced en-US build.