100586 - remove dependency on view from gfx

Status: RESOLVED INACTIVE

(Core :: Layout, defect)

Description

[Jon Smirl]

Patch removes one gfx API that depended on internals of the view directory. 
Three places in the tree that called this API were adjusted to use other gfx 
APIs.

removed:
NS_IMETHOD  CreateRenderingContext(nsIView *aView, nsIRenderingContext 
*&aContext) = 0;

This allows gfx to be build with depending on view.

Comment 1

[Jon Smirl]

Attachment: remove dependency on view

Comment 2

[Alec Flett]

this looks reasonable to me.. are nsIWidgets not refcounted?
Since I didn't know that until now, I'll leave the r= to someone else (marc?)
and then I'll sr=

Comment 3

[Marc Attinasi]

Comment on attachment 49916 [details] [diff] [review]
remove dependency on view

r=attinasi

Comment 4

[Jon Smirl]

Had to fix a new use in nsSelection.cpp. Change view to widget on gfx call, 
widget is already a variable.

Also, this should not be in the patch, it is part of SVG support....

Index: mozilla/gfx/src/windows/nsDrawingSurfaceWin.cpp
===================================================================
RCS file: /cvsroot/mozilla/gfx/src/windows/nsDrawingSurfaceWin.cpp,v
retrieving revision 3.7
diff -r3.7 nsDrawingSurfaceWin.cpp
390c390,394
<         depth = ::GetDeviceCaps(aDC, BITSPIXEL);
---
>         if (aFlags & NS_CREATEDRAWINGSURFACE_24BIT)
>           depth = 24;
>         else
>           depth = ::GetDeviceCaps(aDC, BITSPIXEL);
>  

Comment 5

[Alec Flett]

Jon: I don't see the nsSelection change you're talking about - do you have a new
patch?

Comment 6

[Jon Smirl]

Index: mozilla/content/base/src/nsSelection.cpp
===================================================================
RCS file: /cvsroot/mozilla/content/base/src/nsSelection.cpp,v
retrieving revision 3.106
diff -u -r3.106 nsSelection.cpp
--- mozilla/content/base/src/nsSelection.cpp	2001/08/21 18:38:20	3.106
+++ mozilla/content/base/src/nsSelection.cpp	2001/09/20 15:15:42
@@ -52,6 +52,7 @@
 #include "nsIDocumentEncoder.h"
 #include "nsIIndependentSelection.h"
 #include "nsIPref.h"
+#include "nsIWidget.h"
 
 // for IBMBIDI
 #include "nsFrameTraversal.h"
@@ -6971,7 +6972,7 @@
 
 	nsCOMPtr<nsIRenderingContext> rendContext;
 
-	rv = deviceContext->CreateRenderingContext(closestView, *getter_AddRefs
(rendContext));		
+	rv = deviceContext->CreateRenderingContext(widget, *getter_AddRefs
(rendContext));		
   
 	if (NS_FAILED(rv))
 		return rv;

Comment 7

[Alec Flett]

jon, I'm actually going to reassign these bugs you filed to you, since you're
the one doing the work

Comment 8

[Alec Flett]

jon, do you have an updated patch? I'll check it in if so..this patch is kind of
outdated..

Comment 9

[Jon Smirl]

check in the widget dependency one and then I'll do this one over

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:dholbert, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 11

[Daniel Holbert [:dholbert]]

If there's anything to be done here at this point, someone can open a new bug about it.