1005921 - Make the callscreen jshint-clean

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Gabriele Svelto [:gsvelto] (PTO)]

The callscreen code contains a number of issues beyond the usual syntax glitches that prevent us from making it jshint-clean.

This includes binding event listeners during the evaluation phase of certain apps as well as caching certains globals (such as navigator.mozTelephony or navigator.mozBluetooth) during evaluation which prevents the relevant components from being instantiable w/o side-effects.

These issues do not cause linter issues directly but affect the unit-tests in such ways that we need horrible hacks to work around them. Those hacks in turn cause the linter to fail spectacularly.

I feel this is important because some of the linter errors may actually be some actual errors on our part.

Comment 1

[Gabriele Svelto [:gsvelto] (PTO)]

Attachment: [PULL REQUEST WIP] Make the callscreen jshint-clean

This is a WIP pull request that cleans up the HandledCall and CallsHandler code but breaks some unit-tests. If you feel adventurous feel free to pick up from here :)

Comment 2

[Kevin Grandon :kgrandon]

Attachment: Pull request

Anthony, just knocking these files off the jshint ignore real quick - Could you review it? Thanks!

Comment 3

[Kevin Grandon :kgrandon]

It looked like the old PR here was obsoleted by work in another bug, since I saw these few files remaining I thought that we should just quickly fix them. Thanks!

Comment 4

[Anthony Ricaud (:rik)]

Comment on attachment 8496591 [details] [review]
Pull request

Ah very cool!

Comment 5

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/8c1c17dc0b87c67d44c8b9df06c43ad78df4f241