1005924 - URL outline is not resized correctly after changing device orientation

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[u421692]

Attachment: edit mode

Steps to reproduce:
1. Open firefox and have the device in portrait mode
2. Tap on URL bar
3. Exit edit mode
4. Change orientation of the device in landscape mode
5. Tap on URL bar

Actual result:
URL bar orange outline from portrait mode reminisce on screen(please see attached video)

Regression window:
Bad build: 2014-04-30
Good build: 2014-05-01
Pushlog: 
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e19812f56952&tochange=b227a707080f
Probably Bug 1000149 was the cause of this regression

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Looks like 1000149 caused this regression.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Kevin Brosnan [:kbrosnan] from comment #1)
> Looks like 1000149 caused this regression.

Definitely - I'm on it.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Find url bar translation with cancel button.

I could have made the urlEditLayout INVISIBLE on hide, or this, and I chose this to avoid drawing more Views on-screen but I honestly don't know what would be more performant.

Comment 4

[Lucas Rocha (:lucasr)]

Comment on attachment 8418211 [details] [diff] [review]
Find url bar translation with cancel button.

Review of attachment 8418211 [details] [diff] [review]:
-----------------------------------------------------------------

That looks fine to me. Please add a comment explaining what this calculation is actually doing.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Find url bar translation with cancel button.

Fix nits.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8418867 [details] [diff] [review]
Find url bar translation with cancel button.

https://hg.mozilla.org/integration/fx-team/rev/c44b4207aa5f

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8418867 [details] [diff] [review]
Find url bar translation with cancel button.

This must be uplifted after bug 1000149.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 1000149

User impact if declined:
  If bug 1000149 is uplifted without this, the url bar will animate incorrectly the first time after a rotation.
 
Testing completed (on m-c, etc.):
  Local testing.
 
Risk to taking this patch (and alternatives if risky):
  Low - a small and well-understood change that can only affect the amount the url bar expands.

String or IDL/UUID changes made by this patch: None

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Michael, the bug is marked as unaffected for 31 and you request an uplift to aurora. The tracking flag is wrong?

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #8)
> Michael, the bug is marked as unaffected for 31 and you request an uplift to
> aurora. The tracking flag is wrong?

The issue is caused by bug 1000149 (a simplification of the UX refresh in aurora) which I hope to uplift.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c44b4207aa5f

Comment 11

[u421692]

Verified as fixed on Alcatel One Touch 8008D(Android 4.1.2), on Nightly 32.0a1(2014-05-08).

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dd74b8815bbc

Comment 13

[u421692]

Verified as fixed on Alcatel One Touch 8008D(Android 4.1.2), on Aurora 31.0a2(2014-05-09).