1005972 - poorly resized window after wake-from-sleep with non-retina external monitor

Status: REOPENED

(Core :: Widget: Cocoa, defect, P3)

Description

[Ben Kelly [:bkelly, not reviewing]]

I came across a bug report on twitter today here:

  https://twitter.com/shinypb/status/463350666484658176

The user is on Aurora 30 on a retina MBP with an external non-retina monitor.  The problem occurs as follows:

  1. FF on external non-Retina monitor.
  2. Sleep machine
  3. Unplug monitor
  4. Wake machine
  5. Tiny unusable FF window shows up.

I assume this is a case of the user having their laptop closed and just wanted to grab it and go without waking it up to gracefully disconnect the monitor.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

See also these comments in bug 794038:

  https://bugzilla.mozilla.org/show_bug.cgi?id=794038#c5
  https://bugzilla.mozilla.org/show_bug.cgi?id=794038#c55

That was two years ago, though.  Did we regress?

Comment 2

[Steven Michaud [:smichaud] (Retired)]

I can't reproduce this, on either OS X 10.7.5 or 10.9.2.  I tested with FF 29 (the current release).

Comment 3

[Jonathan Kew [:jfkthame]]

:bkelly - could you check whether the user has tried starting in Safe Mode and/or running with a fresh profile? Also, does the problem also happen with Release (FF29), or is it a new regression in Aurora?

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

(In reply to Jonathan Kew (:jfkthame) from comment #3)
> :bkelly - could you check whether the user has tried starting in Safe Mode
> and/or running with a fresh profile? Also, does the problem also happen with
> Release (FF29), or is it a new regression in Aurora?

He reports:

1) It does happen with FF29
2) It does not happen with safe mode in Aurora

He's not using any addons, though, so not sure why safe mode would help in this case.

Comment 5

[Jonathan Kew [:jfkthame]]

(In reply to Ben Kelly [:bkelly] from comment #4)
> (In reply to Jonathan Kew (:jfkthame) from comment #3)
> > :bkelly - could you check whether the user has tried starting in Safe Mode
> > and/or running with a fresh profile? Also, does the problem also happen with
> > Release (FF29), or is it a new regression in Aurora?
> 
> He reports:
> 
> 1) It does happen with FF29
> 2) It does not happen with safe mode in Aurora
> 
> He's not using any addons, though, so not sure why safe mode would help in
> this case.

It'd be good to check about:support to see what modified preferences there are in his profile - maybe something there is affecting the behavior.

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

(In reply to Jonathan Kew (:jfkthame) from comment #5)
> It'd be good to check about:support to see what modified preferences there
> are in his profile - maybe something there is affecting the behavior.

So I misread this and asked him to look at about:config.  When it wasn't easily obvious what changed there I asked him to use profile manager to create a new profile.  He can no longer reproduce in either the new or old profile. :-\

I asked him to send me about:support pastebin if it occurs again.

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

Since the user can no longer reproduce I'm going to mark this WFM.  I'll re-open if he reports it again.

Comment 8

[Kevin Simons [:kevsim] (Telenor)]

Attachment: about:support

I was told on IRC (by spohl) to attach about:support to the bug

Comment 9

[Kevin Simons [:kevsim] (Telenor)]

Attachment: Screenshot with tiny minimize/maximize buttons

Comment 10

[Kevin Simons [:kevsim] (Telenor)]

I can also reproduce this simply by unplugging my Thunderbolt display when Firefox 29 is running.

Comment 11

[Kevin Simons [:kevsim] (Telenor)]

I've attached a screenshot where the minimize/maximize buttons are tiny (and the fullscreen button is in the wrong place). I've also seen it happen where the tabs themselves are tiny.

Comment 12

[Stephen A Pohl [:spohl]]

Markus, do tiny minimize/maximize buttons sound familiar to you?

Comment 13

[Markus Stange [:mstange]]

Not in a way that lets me come up with a patch right away ;-)

Somebody who can reproduce this needs to find out whether the "scale" variable in nsChildView::UpdateTitlebarCGContext() has the right value, and if not, why not.

I don't really have time for this at the moment, unfortunately.

Comment 14

[Kevin Simons [:kevsim] (Telenor)]

I'm happy to take a look next week in my free time, but if someone who knows the code has time, that'd of course be better.

Comment 15

[Markus Stange [:mstange]]

Do the buttons redraw at the right size if you hover them, or if window focus changes? If that's the case, we're just not invalidating on the BackingScaleFactor change. Calling NotifyDirtyRegion(RectContainingTitlebarControls()) from nsChildView::BackingScaleFactorChanged() would probably fix that.

Comment 16

[Michael Goff]

I have seen this same problem twice, with the same sequence of events to make it happen. See the attached screenshot. I am using release version 31.0 on OSX 10.9.4.

Comment 17

[Michael Goff]

Attachment: Firefox 31.0 Retina Resize Issue.png

Comment 18

[Michael Goff]

I also just saw this on Mac OS X Yosemite 10.10 when dragging a FF 33.1 window from an external Thunderbolt display to my Macbook Pro 13" retina display, without putting the Mac to sleep or disconnecting the external monitor.

Comment 19

[Henry Bolte]

I am having a similar problem with Firefox and Windows 10.
Whenever my system goes in to sleep mode, my Firefox window is resized (smaller)when I wake the system.
I have the latest fixes for both Firefox and Windows 10.
I am using a Lenovo Z50 laptop and an Acer 23inch external monitor (SNID: 13600767043).

Comment 20

[Tracy Walker [:tracy]]

(In reply to Kevin Simons [:kevsim] (Telenor) from comment #10)
> I can also reproduce this simply by unplugging my Thunderbolt display when
> Firefox 29 is running.

This WFM with both release Fx50 and latest Nightly on macOS 10.12.  However, I am using the HDMI port on the MBP, instead of a Thunderbolt port.

For those able to reproduce this, are you using Thunderbolt to connect to the external monitor?

Comment 21

[Henry Bolte]

Tracy,
I apologize the not being tech savvy enough to know the name of the port I am using for my external monitor, it is the standard cable used for monitors for at least the last 40 years, I thought it was called C2G ?   It is definitely not HDMI.

Again, I am running Windows 10 accepting updates automatically on a Lenovo Z50 laptop and have release 50 of Firefox installed.  I ONLY use the external Acer monitor (and not the laptop monitor)
When I wake my system from SLEEP mode, my Firefox window is smaller (narrower, perhaps 1/3 as wide) than when I was viewing before SLEEP mode.

Comment 22

[Tracy Walker [:tracy]]

Henry,

No worries, Thunderbolt is a Mac thing.  Anyway, I think the Windows version of this bug that you're experiencing is included in bug 1292339.

Comment 23

[Henry Bolte]

Thanks Tracy, I'll try to join that conversation.

Comment 25

[Eric Taylor]

I am getting something similar on macOS 13.0.1 (22A400) with a 16" MBP Apple M1 Max 64gb. Frequently when I wake from sleep any "lightbox" items dependent on window dimensions will be badly miscalculating the dimensions until I force a reload of the web page or open/close the Bookmarks Bar. I believe the issue lies iwth it waking up and rapidly calculating dimensions from the native retina monitor before the external monitor wakes up and the OS moves the window back to the external display. I've only noticed this in the last couple iterations of FireFox (and I've had the MBP for going on a year now, so it seems like it's somehow related to changes in macOS or FF. (And it did this prior to my updating to Ventura as well.)

EXAMPLE SCREENSHOT:
https://i.imgur.com/0SrvZ0m.png

WORKAROUND:
Toggling the Bookmarks Bar closed and back open again recalculates the window size! (Just discovered this.)