1006043 - closing a remote (e10s) tab right after opening it prevents a clean cfx shutdown

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Tomislav Jovanovic :zombie]

opening a remote tab in an e10s window, and promptly closing it (which in sdk-land just calls "remove a xul:tab element") before it is fully loaded, prevents a clean shutdown of the cfx with errors below.

this also happen if i don't even try to close the tab, and simply exit the test (this is running in a test addon, so there is no check for "tabs left open after a test" like in our test suite).

observing with processes explorer reveals that a firefox instance lingers for several seconds _after_ it prints out the summary message, which probably means it holds onto open files from the profile long after it writes 'OK' to a results file (a workaround for bug 894697), while cfx tries to clean up the profile, which throws.

i worked around this by inserting a frame script that sends a message back and only close the tab then. this all doesn't happen without e10s.

i'm pretty sure this is a platform issue, but since the only visible symptom (at least to me) is that it delays the firefox shutdown, it only bites us. 

i'm not sure we should do anything about this, as it might simply go away with other e10s fixes in the platform, but i have spent half the weekend on this, and i'm filing it in case it bites us again.

(this might be the worst but report i have ever filed)


2 of 2 tests passed.

Error Cleaning up: [Error 32] The process cannot access the file because it is being used by another process: 'c:\\temp\\tmpp9hbpl.mozrunner\\content-prefs.sqlite'
Error Cleaning up: [Error 5] Access is denied: 'c:\\temp\\tmpp9hbpl.mozrunner\\extensions\\jid1-DYaXFHAPlHwbgw@jetpack'
Error Cleaning up: [Error 145] The directory is not empty: 'c:\\temp\\tmpp9hbpl.mozrunner\\extensions'
Error Cleaning up: [Error 32] The process cannot access the file because it is being used by another process: 'c:\\temp\\tmpp9hbpl.mozrunner\\parent.lock'
Error Cleaning up: [Error 145] The directory is not empty: 'c:\\temp\\tmpp9hbpl.mozrunner'
Total time: 44.453000 seconds
Program terminated successfully.
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "D:\public\exe\Python27\lib\atexit.py", line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "D:\git\addon-sdk\python-lib\cuddlefish\runner.py", line 542, in maybe_remove_outfile
    os.remove(outfile)
WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'c:\\temp\\harness-stdout-volvsc'
Error in sys.exitfunc:
Traceback (most recent call last):
  File "D:\public\exe\Python27\lib\atexit.py", line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "D:\git\addon-sdk\python-lib\cuddlefish\runner.py", line 542, in maybe_remove_outfile
    os.remove(outfile)
WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'c:\\temp\\harness-stdout-volvsc'

Comment 1

[Tomislav Jovanovic :zombie]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1485

not exactly a solution, more of a brute-force approach..

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/c441dbd2ace67d24a930e93e7af84d6b0d1da083
bug 1006043 - hack around lingering child process

https://github.com/mozilla/addon-sdk/commit/08e366d77b40974700413fac224a5df5f189b150
Merge pull request #1485 from zombie/1006043-double-kill

bug 1006043 - hack around lingering child process, r=@Mossop

Comment 3

[Tomislav Jovanovic :zombie]

the above patch doesn't solve the actual problem, so i'm leaving this open to test/investigate later.

Comment 4

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.