Closed Bug 1006064 Opened 6 years ago Closed 6 years ago
Port make test-perf to 1
46 bytes, text/x-github-pull-request
|Details | Review|
So far we have been running make test-perf on Tarako using the master branch of gaia. This is gonna go horribly wrong if we continue, like with bug 846909. We should port the changes to the test framework to 1.3T and start running the test from that branch.
Assignee: nobody → hub
Whiteboard: [c=automation p=2 s= u=]
Mike, not sure how to go about asking approval to do that. I have a branch where I cherry-picked all the bugs (16) I needed to get this going. The short version is that we can no longer take the risk of having the perf tests broken on Tarako when updating for the new 2.0 stuff - as we have been running them using gaia master. Bug 846909 is one example of changes that break on Tarako.
Bhavana, Per hub's comment 1, how do we go about getting approval to uplift changes to 1.3T? Thanks, Mike
Status: NEW → ASSIGNED
Flags: needinfo?(mlee) → needinfo?(bbajaj)
Priority: -- → P2
Whiteboard: [c=automation p=2 s= u=] → [c=automation p=2 s= u=tarako]
This is the port. Uplifting 17 bugs.
The changes are limited to: 1. The gaia makefile 2. The performance testing code used by make test-perf. Its outside impact should be limited to the integration test, hopefully without side effect. I'll make of that. I can mark the 17 bugs individual for nomination if needed.
Are these uplifts not part of the build(NPOTB) or test/automation only ? if so you can check-in using a=bajaj on the branch https://github.com/mozilla-b2g/gaia/tree/v1.3t directly If these may have an end-user impact or impact to the builds you should follow the landing procedure described here : https://wiki.mozilla.org/Release_Management/B2G_Landing. Basically nominate a bug for being a 1.3t:? blocker once triage makes a call we can go ahead block it and land the patches.
So far my try build seems to break RefTest 15. No idea if it is a fluke or real.
Apparently we never run the R15 test on tarako so we should be fine.
Merge https://github.com/mozilla-b2g/gaia/commit/6badae6610fc111403a24755795e82a675c7c88f I will individually mark all the other bugs as fixed in 1.3t
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.