1006068 - The top of the web page is now too small and two menu bars are intermixed

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[peter]

Attachment: Screen Shot 2014-05-05 at 20.50.42.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0 SeaMonkey/2.26 (Beta/Release)
Build ID: 20140428215742

Steps to reproduce:

On loading any page, the web page loads but the top of the screen layout is too small. The two top menu bars are cojoined. The back and forward arrows are mixed in the with close, minimise page etc. Also I have a problem trying to move the whole page. I can only do this by carefully moving the mouse until I get a change size double ended arrow...if I click and hold this then I can move the actual web page across the screen. This is on an Imac running latest Mavericks 10.9.2, 32Gb, 1600 Mhz.


Actual results:

See above.


Expected results:

Prior to this latest update, there has always been a ribbon bar across the top where one could click and hold to move the window. Also the top menu lines should be spaced out so that the icons are not intermixed.

Comment 2

[Philip Chee]

Two reports so I am confirming this as NEW. cc Stefanh as he's on a Mac.

Comment 3

[Stefan [:stefanh]]

peter,

Thanks for the report. Can you please uninstall/disable the persona and see what happens?

Comment 4

[peter]

I have disabled the themes/top pictures and it is now working properly. Thank you. Hopefully these will work again soon.

Comment 5

[Stefan [:stefanh]]

Thanks for the info. This is quite similar to bug 864034 and my guess is that some core change have caused this.

Comment 6

[Stefan [:stefanh]]

Bug 930094 looks like a candidate here.

Comment 7

[Stefan [:stefanh]]

OK, so this means that lightweight themes are broken on OS X atm. This is not trunk-only, beta/aurora are also broken.

Comment 8

[Stefan [:stefanh]]

Attachment: Make lightweight themes work properly on Mac

Neil, I'm a bit unsure what happens on win/nix when I set the chromemargin attribute (drawtitle is mac-only)... Basically, we need chromemargin to make it work properly on mac. If this regress win/nix I need to find another way (platformCommunicatorOverlay?).

We could do it like thunderbird, but then the transition from lightweight theming isn't as smooth as we want it to be (when unistalling/disabling a lightweight theme there's an instant flash of grey in the upper corners of the window).

Comment 9

[Stefan [:stefanh]]

OK, so I should probably set the chromemargin attribute only when a lightweight theme is installed. But I'm not sure where and how I could do that for all those windows.

Comment 10

[Stefan [:stefanh]]

And I don't need
"window:not([chromemargin]) > #titlebar {
   display: none;" if I always set chromemargin, of course...

Comment 11

[Stefan [:stefanh]]

Comment on attachment 8424492 [details] [diff] [review]
Make lightweight themes work properly on Mac

Let's go with a minimal solution that doesn't affect win/nix.

Comment 12

[Stefan [:stefanh]]

Attachment: New version

OK, so this one is mac-only. The drawtitle attribute is mac-only and it's ignored if chromemargin isn't set.

Comment 13

[Stefan [:stefanh]]

Jens, I think this should be in the release notes for 2.26. The bottom line here is: If you install a lightweight theme, the unified toolbar will shrink so the window's title bar will (see attachment #8417557 [details]) overlap the top toolbar (in the screenshot it overlaps the navigation toolbar).

Comment 14

[Karsten Düsterloh]

Comment on attachment 8424506 [details] [diff] [review]
New version

Hah, and there was /me wondering how I messed up my build this time!

Comment 15

[Stefan [:stefanh]]

https://hg.mozilla.org/comm-central/rev/48b00c92a686

Comment 16

[Stefan [:stefanh]]

Comment on attachment 8424506 [details] [diff] [review]
New version

[Approval Request Comment]
User impact if declined: Lightweight themes broken on OS X.
Testing completed (on m-c, etc.): Tested with a comm-beta build.
Risk to taking this patch (and alternatives if risky): Very small risk since it can't be much worse than it is now.
String changes made by this patch: None.

Comment 17

[Philip Chee]

Comment on attachment 8424506 [details] [diff] [review]
New version

a=me for comm-aurora and comm-beta
a=CLOSED TREE if you need it.

Comment 18

[Stefan [:stefanh]]

https://hg.mozilla.org/releases/comm-aurora/rev/960cb84ee048
https://hg.mozilla.org/releases/comm-beta/rev/70aea5c801fc

Comment 19

[Justin Wood (:Callek)]

Comment on attachment 8424506 [details] [diff] [review]
New version

[Triage Comment]

Approved for SeaMonkey 2.26.1

Comment 20

[Justin Wood (:Callek)]

landing to comm-release for SeaMonkey 2.26.1

$ hg tip
changeset:   20169:6d24ad7fb027
branch:      SEA_2_26_1_RELBRANCH
tag:         tip
parent:      19901:c4c80b09c5a0
user:        [e-mail]
date:        Tue May 20 19:54:13 2014 +0200
summary:     Bug 1006068 - Lightweight themes: title bar overlaps toolbar and no window title is displayed. r=Mnyromyr, sr=Neil,a=Ratty.