1006330 - [e10s] EFF Privacy Badger addon's popup window is empty

Status: VERIFIED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Chris Peterson [:cpeterson]]

STR:
1. Install EFF Privacy Badger addon: https://www.eff.org/privacybadger
2. In a new e10s window, click Privacy Badger's toolbar button.

RESULT:
A popup window appears, but it is empty.

Comment 1

[Jim Mathies [:jimm]]

In the latest beta, the drop down has content, but the list of tracking web sites doesn't populate.

Comment 2

[lewis]

I've got tracking web sites populating in the drop down as of version 34.0a1

(http://f.cl.ly/items/0c2S2B0R3n1a0N3o3j2q/Screen%20Shot%202014-07-23%20at%2014.27.51.png)

Comment 3

[Chris Peterson [:cpeterson]]

Also, when installing Privacy Badger with e10s enabled, Privacy Badger's first run page is blank.

I filed a bug about e10s on Privacy Badger's GitHub repo and linked back to this bug:

https://github.com/EFForg/privacybadgerfirefox/issues/208

Comment 4

[martin]

As of Firefox Nightly BuildID
Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141114030206 CSet: 7f0d92595432

Privacy Badger does not show up in the URL Bar at all

Comment 5

[martin]

Also the Toolbar element for Privacy Badger 0.2.3 does not appear

Comment 6

[Cooper Quintin]

We have fixed the bug regarding the privacy badger toolbar not showing up here: https://github.com/EFForg/privacybadgerfirefox/issues/244

As for E10S support -- it is still a work in progress. Unfortunately it is not as simple as I had hoped. The issue is being tracked here: https://github.com/EFForg/privacybadgerfirefox/issues/208

Comment 7

[martin]

Testing with Firefox Build: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:38.0) Gecko/20100101 Firefox/38.0 ID:20150125030202 CSet: c18776175a69

Privacy Badger 0.2.5

The Privacy Badger Icon now shows up on the toolbar automatically.

However it still does not show any tracking information with e10s enabled.

Comment 8

[Andrei Petcu]

Seems to work on the latest Firefox Nightly with the latest Privacy Badger.
Should this bug be marked as resolved? Is there something I'm missing?

Comment 9

[Chris Peterson [:cpeterson]]

Privacy Badger 1.0.5 still does not work with e10s. I see the following browser console errors when trying to load cnn.com:

privacybadger:Object { stack: "", 5 more… } runner.js:166
privacybadger:Object { stack: "", 5 more… } Promise-backend.js:936

fileName:"resource://gre/modules/commonjs/toolkit/loader.js -> resource://jid1-mnnxcxisbpnsxq-at-jetpack/lib/sha1.js"
lineNumber:24
message:"missing ] after element list"

stack:"@resource://jid1-mnnxcxisbpnsxq-at-jetpack/lib/sha1.js:24:NaN
@resource://jid1-mnnxcxisbpnsxq-at-jetpack/lib/policyCheck.js:7:18
@resource://jid1-mnnxcxisbpnsxq-at-jetpack/lib/heuristicBlocker.js:16:5
@resource://jid1-mnnxcxisbpnsxq-at-jetpack/lib/main.js:25:26
run@resource://gre/modules/commonjs/sdk/addon/runner.js:147:19
startup/</<@resource://gre/modules/commonjs/sdk/addon/runner.js:87:9
Handler.prototype.process@resource://gre/modules/Promise-backend.js:933:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise-backend.js:812:7
Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise-backend.js:743:11
this.PromiseWalker.schedulePromise@resource://gre/modules/Promise-backend.js:775:7
this.PromiseWalker.completePromise@resource://gre/modules/Promise-backend.js:710:7
handler@resource://gre/modules/commonjs/sdk/addon/window.js:56:3
EventListener.handleEvent*EventTargetInterposition.methods.addEventListener@resource://gre/modules/RemoteAddonsParent.jsm:624:5
AddonInterpositionService.prototype.interposeProperty/desc.value@resource://gre/components/multiprocessShims.js:160:52
@resource://gre/modules/commonjs/sdk/addon/window.js:54:1
startup/<@resource://gre/modules/commonjs/sdk/addon/runner.js:72:21
Handler.prototype.process@resource://gre/modules/Promise-backend.js:933:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise-backend.js:812:7
Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise-backend.js:743:11
this.PromiseWalker.schedulePromise@resource://gre/modules/Promise-backend.js:775:7
this.PromiseWalker.completePromise@resource://gre/modules/Promise-backend.js:710:7
listener/<@resource://gre/modules/sdk/system/Startup.js:51:46
"

Comment 10

[Chris Peterson [:cpeterson]]

The errors in comment 9 are not e10s regressions. They are regressions from bug 1220564 removing support for SpiderMonkey's non-standard array comprehension syntax. I submitted a fix to Privacy Badger upstream:

https://github.com/EFForg/privacybadgerfirefox/pull/722

Comment 11

[kinwolf]

Well, on Firefox developer 48.0a2 and PB 1.7.0, PB always says there are no trackers detected for any webpages.  Still broken.

Comment 12

[kinwolf]

(In reply to kinwolf from comment #11)
> Well, on Firefox developer 48.0a2 and PB 1.7.0, PB always says there are no
> trackers detected for any webpages.  Still broken.

I should add that if I open a non-e10s tab, it work properly.

Comment 13

[:shell escalante]

Great add-on name! i see Privacy Badger just released a new version 1.8.0.  Is that e10s compatible?  e10s has hit release in 48, but is excluding add-ons (so users with add-ons won't get e10s activated).  

we'll be targeting webextensions and MPC=true (multi-processor compliant) first over the next couple of versions (50-52 in release - depending on quality metrics that we find in Betas).

Comment 14

[Cooper Quintin]

Privacy Badger is *NOT* E10S compatible, but the issue in firefox 48 seems to have been not related to E10S. I have a web extensions version of privacy badger which is ready to go, except for one glitch. There is no good way right now to transfer data from the jetpack version to the web extensions version since they will have two different IDs if I understand correctly. It appears that the way to solve this is with embedded web extensions, which is being worked on in bug 1252227. I think that the E10S rollout should be delayed until embedded web extensions is ready. Right now I am faced with the choice of releasing the webext version of privacy badger and having my users loose all of their data, or sticking with this outdated version of privacy badger and hoping that embedded web extensions gets released before e10s breaks privacy badger completely.

Comment 15

[Cooper Quintin]

Can we rename this to e10s-privacybadger?

Comment 16

[Cooper Quintin]

The original issue in this bug report (popup window empty) is fixed as of privacy badger 1.8.0. Should we continue discussing e10s compatibility in here, or open a separate issue?

Comment 17

[Clément Lefèvre]

(In reply to Cooper Quintin from comment #16)
> The original issue in this bug report (popup window empty) is fixed as of
> privacy badger 1.8.0. Should we continue discussing e10s compatibility in
> here, or open a separate issue?

I think opening a new bug for any new specific issue that might occur is the way to go.

Anyway, they'll now have WebExtensions port as a priority issue I guess, as 57 will come out pretty quickly from now on.

Closing as fixed.