1006378 - [Stingray] Add selection border support to homescreen-stingray

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

+++ This bug was initially created as a clone of Bug #1002350 +++

add selection border support to homescreen-stingray

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: patch for this bug

Please review this patch.

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8418617 [details] [review]
patch for this bug

Hi all,

The patch had been updated to address Luke's concerns.

Please review it.

Comment 3

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8418617 [details] [review]
patch for this bug

Looks great! Thanks.

Comment 4

[Luke Chang [:lchang] (inactive)]

Hi John,

It occurs to me that maybe we cannot always set the container of borders to document.body. Otherwise, the borders will be not able to follow its target element when we scroll the parent element of the target instead of document.body.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8418617 [details] [review]
patch for this bug

Ok. Let's reconsider it. I clear all review flag and create a new version.

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8418617 [details] [review]
patch for this bug

This PR had revised to address Luke's concern. Please review it.

Comment 7

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8418617 [details] [review]
patch for this bug

Looks great! Thanks!

Comment 8

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Comment on attachment 8418617 [details] [review]
patch for this bug

r=me, nice job!!!

Comment 9

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/faf02451acb7e267a38f7e8116c1b1d888319fd8