Closed
Bug 1006566
Opened 11 years ago
Closed 11 years ago
Unify the common DataStore tests between the main thread and the worker thread.
Categories
(Core :: DOM: Workers, defect)
Core
DOM: Workers
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: airpingu, Assigned: airpingu)
References
Details
Attachments
(3 files)
1.43 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
53.96 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
2.03 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
After fixing bug 1006562:
is(cursor.store, gStore, "Cursor.store is the store");
we can then unify the common part between:
1. file_basic.html and file_basic_worker.js
2. file_sync.html and file_sync_worker.js
Assignee | ||
Comment 1•11 years ago
|
||
To make no difference for the tests between the main thread and the worker, so that we can refactorize them later.
Attachment #8420779 -
Flags: review?(amarchesini)
Assignee | ||
Comment 2•11 years ago
|
||
This is the main fix. In the worker, we can use the dedicated importScripts(...) to import the needed JS file.
Attachment #8420780 -
Flags: review?(amarchesini)
Assignee | ||
Comment 3•11 years ago
|
||
I didn't align the codes in the previous patches for your convenience of reviews, which are eventually aligned in this patch. ;)
Attachment #8420781 -
Flags: review?(amarchesini)
Assignee | ||
Comment 4•11 years ago
|
||
Updated•11 years ago
|
Attachment #8420779 -
Flags: review?(amarchesini) → review+
Updated•11 years ago
|
Attachment #8420780 -
Flags: review?(amarchesini) → review+
Updated•11 years ago
|
Attachment #8420781 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2a78eb9c84fc
https://hg.mozilla.org/mozilla-central/rev/217a9ba98fc8
https://hg.mozilla.org/mozilla-central/rev/c0f7841fbe96
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•