[ResourceTiming] Redirected iframe inserts 2 entries into buffer

RESOLVED FIXED in mozilla32

Status

()

defect
RESOLVED FIXED
5 years ago
5 months ago

People

(Reporter: valentin.gosu, Assigned: valentin.gosu)

Tracking

unspecified
mozilla32
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

On a page with 
<iframe sandbox="allow-scripts" src="http://test2.com/index2.html"></iframe>
where the page is redirected with a 301 to another domain, there are 2 resource timing entries with the same name.

This does not happen with a redirected img tag.
Assignee: nobody → valentin.gosu
Status: NEW → ASSIGNED
Comment on attachment 8421454 [details] [diff] [review]
Redirected iframe inserts 2 entries into resource timing buffer

Review of attachment 8421454 [details] [diff] [review]:
-----------------------------------------------------------------

This patch sets the mTimingEnabled flag to false for the old channel, or else there will be 2 resources with the same name.
Also passing the initiatorType from the old channel to the new one.
Attachment #8421454 - Flags: review?(honzab.moz)
Comment on attachment 8421454 [details] [diff] [review]
Redirected iframe inserts 2 entries into resource timing buffer

Review of attachment 8421454 [details] [diff] [review]:
-----------------------------------------------------------------

Note: setting the flag is only necessary because the iframe ends up adding an entry to the buffer, even if it was redirected.
This only happens for the first load of the page because of bug 1009360
Attachment #8421454 - Flags: review?(honzab.moz) → review?(mcmanus)
Attachment #8421454 - Flags: review?(mcmanus) → review+
https://hg.mozilla.org/mozilla-central/rev/8635607dedea
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.