Closed
Bug 1006589
Opened 10 years ago
Closed 10 years ago
Hovering an identifier will sometimes remove the highlighting of the line where the debugger is paused
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 32
People
(Reporter: vporof, Assigned: vporof)
Details
Attachments
(1 file)
13.10 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
Whenever you're paused in the debugger, the corresponding line has a blue background, referred to as the "debug location". This highlight can get lost when hovering identifiers, because hovering stuff may perform an evaluation, which blows away the stack. Blowing away the stack removes the debug location, and we're relying on setting it again when the new frames are retrieved. However, this doesn't always happen.
Assignee | ||
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8418117 [details] [diff] [review] v1 Review of attachment 8418117 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/debugger/debugger-panes.js @@ +2020,5 @@ > // to select text in the editor. > + let isResumed = gThreadClient && gThreadClient.state != "paused"; > + let isSelecting = DebuggerView.editor.somethingSelected() && e.buttons > 0; > + let isPopupVisible = !this._tooltip.isHidden(); > + if (isResumed || isSelecting || isPopupVisible) { this improves readability quite a bit.
Attachment #8418117 -
Flags: review?(rcampbell) → review+
https://hg.mozilla.org/mozilla-central/rev/df8bf3b71adb
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Comment 4•10 years ago
|
||
Hi Victor, sorry had to backout this cset from m-c (and will also backout from the other integrations trees) because it seems the test is very fragile and so we have frequent test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=39252805&tree=Mozilla-Central
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 5•10 years ago
|
||
Backout: https://hg.mozilla.org/integration/fx-team/rev/2a03b34c8953
Assignee | ||
Comment 6•10 years ago
|
||
Hopefully the test is fixed now: https://tbpl.mozilla.org/?tree=Try&rev=a85a5e855e3d
Assignee | ||
Comment 7•10 years ago
|
||
Relanded: https://hg.mozilla.org/integration/fx-team/rev/57430c4db8bd
Whiteboard: [fixed-in-fx-team]
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/57430c4db8bd
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•