1006595 - Add domUtils.GetCSSSubPropertiesForProperty, getCSSPropertyIsShorthand, CSSPropertySupportsType (Color, Gradient etc.)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

We would like a few extra utility methods in DOMUtils that allow us to gather a little extra information about CSS properties.

These are:
void getCSSSubPropertiesForProperty(in AString aProperty,
                                      [optional] out unsigned long aLength,
                                      [array, size_is(aLength), retval] out wstring aValues);

bool getCSSPropertySupportsColor(in AString aProperty);
bool getCSSPropertySupportsGradient(in AString aProperty);
bool getCSSPropertyIsShorthand(in AString aProperty);

Ideally, we would use getCSSPropertySupportsType instead of getCSSPropertySupportsColor and getCSSPropertySupportsGradient but I couldn't find a simple way to get that to expose the variants from nsCSSProps.h to JS.

Probably 'cos I am a JS hacker.

Can somebody have a quick look over the code, suggest any improvements and let me know how to expose the variants?

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: extra-css-info.patch-1006595.patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Those variants are a bit of an implementation detail that I think we'd rather not expose...

Comment 3

[Boris Zbarsky [:bzbarsky]]

That said, the implementations could obviously be shared internally, with a utility function that takes a variant id.

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

API:
bool GetCSSSubPropertiesForProperty(in AString aProperty); // Already in patch
bool getCSSPropertyIsShorthand(in AString aProperty); // Already in patch
bool getCSSPropertySupportsType(variant bits from idl);

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Add some APIs on inIDOMUtils to allow determining the subproperties of a CSS shorthand, whether a property is a shorthand, and whether a given property supports a given type of value

Mike, please double-check the behavior of NUMBER/INTEGER and see if it's the one you want

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Boris Zbarsky [:bz] from comment #6)
> Mike, please double-check the behavior of NUMBER/INTEGER and see if it's the
> one you want

This is exactly what we need... thanks.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8445930 [details] [diff] [review]
Add some APIs on inIDOMUtils to allow determining the subproperties of a CSS shorthand, whether a property is a shorthand, and whether a given property supports a given type of value

r=dbaron

Comment 9

[Boris Zbarsky [:bzbarsky]]

Added the missing IID rev and https://hg.mozilla.org/integration/mozilla-inbound/rev/cc0c09414a1c

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cc0c09414a1c

Comment 11

[Sebastian Zartner [:sebo]]

Please document this at https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/inIDOMUtils.

Sebastian