1006632 - Preserve Bugzilla user IDs

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P1)

Description

[Mark Côté [:mcote]]

Right now, the only Bugzilla user info we store in Review Board is login (email address), real name, and can_login.  We identify users by their email address.

However, Bugzilla users' email addresses can change.  In our current system, when they logged into Review Board using their new address, it would create a new user which would not be associated with any reviews.

Instead, we need to set the Review Board user id to the Bugzilla user id.  This will probably mess up the autoinc, but as long as we only ever insert users this way, it should be fine.  Note that user ID 1 in Review Board is reserved for the local admin, but in BMO, at least, we use 1 for nobody (for unassigned reviews), who shouldn't be able to log into Review Board, so this isn't a problem.

The fix is easy, but we'll need a migration script for the existing installs.  The simplest way to do this is to drop all users who aren't associated with any review requests/reviews/etc. and then query Bugzilla for the IDs of the remaining users (warning about any users that can't be found).  Most users have probably been inserted as a result of autocomplete calls anyway, and they won't be associated with any reviews.

Comment 1

[Mark Côté [:mcote]]

Fixed by creating a new model.

https://github.com/mozilla/rbbz/commit/a229581bc5369baee0d858041b0597551bc28e34