1006670 - Add UI Telemetry for 'Switch to native application' android icon

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Perhaps people are not aware of the android icon for switching to a native application. There is add-on created that adds a menu item. In their screenshot for the add-on is the android icon!

https://addons.mozilla.org/en-us/android/addon/open-native-app/

It would be handy to know how often or how little this is used

From IRC:

> liuche: telemetry on all page actions, to see which ones people are using

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: uitelemetry-helperapp v0.1

Simple patch to add a probe for when a user taps the helperapp pageaction

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: fix-sessions v0.1

Unrelated, but I found two sessions with extraneous ":" in the name. This removes them.

Comment 3

[Chenxia Liu [:liuche]]

Comment on attachment 8418695 [details] [diff] [review]
uitelemetry-helperapp v0.1

Review of attachment 8418695 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great.

Comment 4

[Chenxia Liu [:liuche]]

Comment on attachment 8418696 [details] [diff] [review]
fix-sessions v0.1

Review of attachment 8418696 [details] [diff] [review]:
-----------------------------------------------------------------

Technically, we should be updating the version, but I'd be inclined to let it slide since we haven't been filtering on that...

Make sure to request a? uplift for this.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

I agree about the versioning. If this had gone to Beta or we had scripts depending on the name, we really would need to bump the version. We get off easy with this only being a few days old.

remote:   https://hg.mozilla.org/integration/fx-team/rev/560c49efcad5
remote:   https://hg.mozilla.org/integration/fx-team/rev/21e93d53788a

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

and pushed a bustage fix:
https://hg.mozilla.org/integration/fx-team/rev/195a91b45fd6

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/560c49efcad5
https://hg.mozilla.org/mozilla-central/rev/21e93d53788a
https://hg.mozilla.org/mozilla-central/rev/195a91b45fd6

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8418695 [details] [diff] [review]
uitelemetry-helperapp v0.1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Needed for before/after testing of things that will land on Fx32
Testing completed (on m-c, etc.): Working on m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8418696 [details] [diff] [review]
fix-sessions v0.1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Cleanup for some telemetry session names. We want to fix this ASAP.
Testing completed (on m-c, etc.): Working on m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/3dc38a7dfdbc
remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/7234179747ab


(I put the bustage fix into the main patch)