1006844 - ADB helper doesn't work on Windows XP Home

Status: RESOLVED WORKSFORME

(DevTools Graveyard :: WebIDE, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

As reported on GH[1], the ADB Helper does not work in XP Home, because it does not have the program `tasklist`.

The libadb addon may resolve this, as it doesn't seem to use tasklist.

[1]: https://github.com/mozilla/r2d2b2g/issues/892

Comment 1

[Alexandre Poirot [:ochameau]]

I haven't tried on XP but _isAdbRunning, which contains references to tasklist.exe isn't used in adb helper. The function is in adb.js but isn't called.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Alexandre Poirot (:ochameau) from comment #1)
> I haven't tried on XP but _isAdbRunning, which contains references to
> tasklist.exe isn't used in adb helper. The function is in adb.js but isn't
> called.

Ah okay, you may be right.  The original reporter's question was about the 1.1 simulator codebase, and I assumed the ADB helper would be the same after just searching for "tasklist" in the code.  I'll look a bit more later on.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Marking UNCONFIRMED for now, since I don't have XP Home to test this.

Comment 4

[Petruta Horea [:phorea], Desktop Test Engineering (back on Sep 5th)]

Ryan, I can test this under Win XP, if it is still necessary now that WebIDE replaces AppMan and only latest simulator versions are available.

Please let me know how I could help.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Sure, that would be helpful!  First, make sure you have the latest version of the ADB Helper add-on, which is currently 0.5.2.

Then, you would need to connect a real device and see if WebIDE recognizes and can connect to it.

Also, I believe it's important to use XP Home (not Pro) to test this bug.

Comment 6

[Petruta Horea [:phorea], Desktop Test Engineering (back on Sep 5th)]

Attachment: XPHome_FlameDevice.png

Ryan, please see attached: IT installed XP Home SP3 2002 edition and I managed to connect a Flame device using the guide https://developer.mozilla.org/en-US/Firefox_OS/Developer_phone_guide/Flame.
Latest ADB Helper add-on 0.5.2 was automatically installed and I had no problems to connect to the device.

Let me know if I should investigate something else.

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Great!  That sounds like a good enough test to me.