Closed Bug 1007145 Opened 10 years ago Closed 9 years ago

Unhook Breakpad from SPS

Categories

(Core :: Gecko Profiler, defect)

Product:
Core
Component:
Gecko Profiler
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: ted, Unassigned)

References

Details

Now that we're using LUL for unwinding, we should make sure we're using it on all platforms and unhook Breakpad from SPS so we can remove the Breakpad integration code and our local Breakpad patches. Julian said he thinks it should be mostly unused except perhaps for native unwinds on OS X.
Native unwind on OS X use a nsStackWalk manual frame pointer. I did use breakpad unwinds from time to time on fennec but you have to opt onto special options, it's not the default. I think it's safe to just remove today.
I started looking into this in order to get back in sync with upstream Breakpad, but I don't understand all the intricacies of the profiler code. If someone could either point me in the right direction or write the patch I would appreciate it.
Blocks: 1069556
My understanding is that the breakpad code in the profiler is never used by default. Julian as switch to a custom unwinder called LuL (which we were supposed to start using on Linux but I believe we haven't yet?). Confirm with Julian but I expect the answer is you can probably just remove the callsite to breakpad functions from the profiler code, just make sure we still compile. The code should be off by default.
I tried hacking things out but either I removed too much or I don't know what to remove because I wound up with a bunch of linker errors. (Linux, 64-bit)
Ted, do you have a w-i-p patch I can poke at?
AFAICT this got mostly fixed along the way, and what little is left I can deal with in bug 1069556.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.