1007190 - Separate out handleWindowClose from MozSocialAPI so that it can be used by Loop

Status: RESOLVED DUPLICATE of bug 1000007

(Hello (Loop) :: Client, defect)

Description

[Mark Banner (:standard8)]

The function `handleWindowClose` is useful for setting up handling of window.close. We'd like to have it available for loop as well as for Social.

The best way seems to move this into the new Chat.jsm and make it accessible from there.

Comment 1

[Mark Banner (:standard8)]

Attachment: Separate out handleWindowClose from MozSocialAPI so that it can be used by Loop.

This does the separation. Chat.jsm seems to be the most logical place for this. I'll start a try run in a bit.

Comment 2

[Mark Banner (:standard8)]

https://tbpl.mozilla.org/?tree=Try&rev=3f91387613a2

Comment 3

[Mark Banner (:standard8)]

Attachment: Use the new exported function for handling panel and chatbox closes in Loop.

Since we can't land this part in mozilla-central at the moment (as we can't land the rest of loop), here's the additional two-line change that loop needs to use the newly separated out function in the previous patch.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

TBH, I don't think it makes sense in Chat.jsm - it is used for all panels, not just chats.  So I think grabbing it directly from MozSocialAPI.jsm is fine, but it should have a better name - something like hookWindowCloseForPanelClose() or hookWindowCloseToClosePanel() or something.

I'm also think this should just be incorporated into the patch to land MozLoopAPI.jsm - it's difficult to r+ a patch that touches code that's not yet in the tree and doesn't yet have r+

Comment 5

[Mark Banner (:standard8)]

Ok, this is now wrapped into the patch on bug 1000007.

Comment 6

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8418814 [details] [diff] [review]
Separate out handleWindowClose from MozSocialAPI so that it can be used by Loop.

Clearing requests on closed bugs.

Comment 7

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8419437 [details] [diff] [review]
Use the new exported function for handling panel and chatbox closes in Loop.

Clearing requests on closed bugs.