Closed
Bug 1007215
Opened 11 years ago
Closed 10 years ago
Add UI telemetry for Casting actions
Categories
(Firefox for Android Graveyard :: Screencasting, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 33
People
(Reporter: mfinkle, Assigned: mfinkle)
References
Details
Attachments
(1 file)
2.72 KB,
patch
|
liuche
:
review+
|
Details | Diff | Splinter Review |
We should add probes for casting events:
* Start casting via contextmenu
* Start casting via pageaction
* Start casting via video element control
We might want more metrics later.
Assignee | ||
Comment 1•10 years ago
|
||
This patch does the basics. It adds a "cast.1" event and reuses the "pageaction", "contextmenu" and "button" methods.
I pulled out handleContextMenu to give us an easy way to add the event for contextmenus instead of binding directly to the function to start casting.
Assignee: nobody → mark.finkle
Attachment #8438074 -
Flags: review?(liuche)
Comment 2•10 years ago
|
||
Comment on attachment 8438074 [details] [diff] [review]
cast-telemetry v0.1
Review of attachment 8438074 [details] [diff] [review]:
-----------------------------------------------------------------
Add the event to TelemetryContract with a comment of how this is only in JS - alternatively, add this to the documentation index.rst.
Attachment #8438074 -
Flags: review?(liuche) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Comment 4•10 years ago
|
||
I forgot to add the doc changes Chenxia requested:
https://hg.mozilla.org/integration/fx-team/rev/1d64be7e70d1
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7e3c45fac298
https://hg.mozilla.org/mozilla-central/rev/1d64be7e70d1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•