1007281 - [Homescreen] bookmarking sites will place icon on its own row with a horizontal Row separating it

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Tony Chung [:tchung]]

when bookmarking a website to the vertical homescreen, it's unnecessary displaying it on its own row and adding an extra Horizontal Row.  what a waste of space.   Plus the icons are blurry on the flame

See screenshot.

repro:
1) install 2.0 nightly on Flame 
Gaia      870a5c518742665d36b17e7e88c2ab07d440b94c
Gecko     https://hg.mozilla.org/mozilla-central/rev/417acde736e7
BuildID   20140507040203
Version   32.0a1
ro.build.version.incremental=76
ro.build.date=Mon Apr 14 14:02:50 CST 2014
2) enable vertical homescreen mode
3) launch a webpage, and bookmark the site to homescreen
4) open homescreen, scroll down, and verify the awkward placements with Horizontal rows shown

Expected:
- bookmarked apps are displayed in same rows, no HR seperator

Actual:
- bookmarked apps are displayed in each row

Comment 1

[Tony Chung [:tchung]]

Attachment: screenshot

Comment 2

[Kevin Grandon :kgrandon]

It's probably too early to start filing bugs on the vertical homescreen, but we can fix this pretty quickly.

We've also just spun up this etherpad to be a sort of revolving "top 5 list" until feature complete is done: https://etherpad.mozilla.org/homescreen2-0-bugs

Comment 3

[Tony Chung [:tchung]]

(In reply to Kevin Grandon :kgrandon from comment #2)
> It's probably too early to start filing bugs on the vertical homescreen, but
> we can fix this pretty quickly.
> 
> We've also just spun up this etherpad to be a sort of revolving "top 5 list"
> until feature complete is done:
> https://etherpad.mozilla.org/homescreen2-0-bugs

sounds good.  will dump any testing issues in the etherpad for this current first sprint.

Comment 4

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Hey Cristian - could you give this a quick review when you get a chance? Thanks!

Comment 5

[Kevin Grandon :kgrandon]

There is currently an extra commit in there to run the tests a bunch and verify them on travis. I'm also running this on try: https://tbpl.mozilla.org/?tree=Try&rev=5c10181b1a55

Comment 6

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8419076 [details] [review]
Github pull request

LGTM. Good job. Calendar failed in marionette but I think that is not related to this bug

Comment 7

[Kevin Grandon :kgrandon]

(In reply to Cristian Rodriguez (:crdlc) from comment #6)
> Comment on attachment 8419076 [details] [review]
> Github pull request
> 
> LGTM. Good job. Calendar failed in marionette but I think that is not
> related to this bug

Yeah, it was an unrelated failure and that test has since been disabled. Thanks for the review. The whole divider thing is a bit weird - maybe we can clean this up.

This also gives us a base to build more bookmark tests on so I'm excited about that.

Comment 8

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/037755e526d4c84e54bc94b875146988a0c1fe0e

Comment 9

[Kevin Grandon :kgrandon]

Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.