Closed Bug 1007285 Opened 6 years ago Closed 6 years ago

Length property of the (Weak){Map,Set} constructors should be 1

Categories

(Core :: JavaScript: Standard Library, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: fscholz, Assigned: Swatinem)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #975412 +++

From the April 27, 2014 Draft Rev 24 ECMAScript specification change list:

"* Changed length property value of Symbol, Map, Set, WeakSet, WeakMap to *1* to be consistent with most other built-in constructors"

With that, changes made in bug 975412 need to be 1 instead of 0.
Assignee: nobody → arpad.borsos
Status: NEW → ASSIGNED
Attachment #8419300 - Flags: review?(jorendorff)
Comment on attachment 8419300 [details] [diff] [review]
collectionlength.patch

Review of attachment 8419300 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch!

::: js/src/jit-test/tests/collections/WeakMap-surfaces.js
@@ +27,5 @@
> +    assertEq(desc.value.length, arity);
> +}
> +
> +// XXX: WeakMap#get implementation has an undocumented 2nd argument
> +//checkMethod("get", 1);

Ah, yes. I filed bug 1009349 to get rid of this useful feature.
Attachment #8419300 - Flags: review?(jorendorff) → review+
Tell us what you really think.  :-D
https://hg.mozilla.org/mozilla-central/rev/e2e131ffc437
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.